Skip to content

Commit

Permalink
Fix Principal in AWS verification bucket policy (#2266)
Browse files Browse the repository at this point in the history
In testing the new AWS user verification feature (see #2121), we found
that the bucket policy written in the code didn't match the policy I had
actually set for the `bm-uverify-test1` demo bucket. (Sorry, I guess I
never tested the final version of that code.)

We need to allow *any* principal, not only principals matching a
pattern.

This new version of the policy has been tested on my personal AWS
account, so hopefully it should work when we do the same on the
PhysioNet account.
  • Loading branch information
tompollard authored Jul 24, 2024
2 parents f74b2dc + 4d8b29e commit 72fd0a9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion physionet-django/user/awsverification.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def configure_aws_verification_bucket(bucket_name):

# This must match the set of allowed principals
# (see parse_aws_user_arn above).
principal = "arn:aws:iam::*:user/*"
principal = "*"

# This must match the required verification key
# (see get_aws_verification_key above).
Expand Down

0 comments on commit 72fd0a9

Please sign in to comment.