-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exp/3 pca seq #909
base: main
Are you sure you want to change the base?
Exp/3 pca seq #909
Conversation
… following the nomenclature in other .tsv files
Thank you @pablosmig! It's been fun to hack with you at Brainhack Donostia. I'll finish the PR and share with the core developers team. |
@tsalo @jbteves @handwerkerd where do you think would be a good place to save the PCA variance explained plots that have the Kundu options incorporated? |
I guess the core issue is that the kundu method isn't finding a local minimum so it's not actually a plot and there isn't even a threshold. The number of components retained would be an easy addition to Any other information that's looking for a home? |
Hopefully I'm not completely missing the point here, but this could be added to the existing plots - not as a threshold, but as maybe individual filled circles on the lines (or along the x-axis) indicating which components were selected. Such that the user can see that the three main methods would have picked threshold x, y, z and 'kundu' would have picked most of the components below that threshold and then a few beyond it. |
Experimenting with issue #860.
Non functional changes and breaks many tests.