Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from util.which to shutil.which #41

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Switch from util.which to shutil.which #41

merged 1 commit into from
Nov 12, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Nov 5, 2023

See: MDAnalysis/mdanalysis#3649

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #41 (ba9c68b) into main (d65dc01) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

tylerjereddy
tylerjereddy approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is passing, and this should obviously be merged to reduce maintenance burden.

@tylerjereddy tylerjereddy merged commit 83bfc40 into main Nov 12, 2023
18 checks passed
@tylerjereddy tylerjereddy deleted the which-update branch November 12, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjereddy tylerjereddy tylerjereddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IAlibay @tylerjereddy