WIP: Add Python 3.12 to CI build matrix #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MDA doesn't support 3.12 yet |
Seems so, would you like it if I keep this open for when MDA does or just close the PR and address it later? |
ianmkenney
changed the title
|
I'm always of the view that PRs pending upstream changes should be kept open. |
IAlibay
reviewed
Oct 28, 2023
| @@ -43,7 +43,7 @@ jobs: | |||
| matrix: | |||
| # os: [macOS-latest, ubuntu-latest, windows-latest] | |||
| os: [ubuntu-latest, macOS-latest] | |||
| python-version: ["3.9", "3.10", "3.11"] | |||
| python-version: ["3.9", "3.10", "3.11", "3.12"] | |||
There was a problem hiding this comment.
If you put an exclude for the combination of py3.12 + latest then this should work
|
Closing as superseded by #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
PR Checklist