Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove x86 pin setup-miniconda #134

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Remove x86 pin setup-miniconda #134

merged 1 commit into from
Jul 22, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jul 22, 2024

This seems to be forcing some kind of x86 compatibility build of Python on osx-arm64, removing makes the action pick up the right installer.

You can see this action for more details: https://github.com/MDAnalysis/mdahole2/actions/runs/10024096447/job/27705759572

This seems to be forcing some kind of x86 compatibility build of Python on osx-arm64, removing makes the action pick up the right installer.

You can see this action for more details: https://github.com/MDAnalysis/mdahole2/actions/runs/10024096447/job/27705759572
IAlibay added a commit to MDAnalysis/transport-analysis that referenced this pull request Jul 22, 2024
IAlibay added a commit to MDAnalysis/waterdynamics that referenced this pull request Jul 22, 2024
IAlibay added a commit to MDAnalysis/mdaencore that referenced this pull request Jul 22, 2024
IAlibay added a commit to MDAnalysis/PathSimAnalysis that referenced this pull request Jul 22, 2024
@IAlibay IAlibay requested a review from lilyminium July 22, 2024 02:42
IAlibay added a commit to MDAnalysis/waterdynamics that referenced this pull request Jul 22, 2024
* Remove x86_64 env build pin

See: MDAnalysis/cookiecutter-mdakit#134

* Update requirements.yaml
IAlibay added a commit to MDAnalysis/mdaencore that referenced this pull request Jul 22, 2024
@@ -65,7 +65,6 @@ jobs:
python-version: {{ '${{ matrix.python-version }}' }}
environment-file: devtools/conda-envs/test_env.yaml
add-pip-as-python-dependency: true
architecture: x64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other reviewers: x64 is a shorthand for x86_64.

@IAlibay
Copy link
Member Author

IAlibay commented Jul 22, 2024

Thanks @RMeli - it's a small change so I'll go with one review for merge.

@IAlibay IAlibay merged commit 99b1fb9 into main Jul 22, 2024
12 checks passed
@IAlibay IAlibay deleted the arch-pinning-issues branch July 22, 2024 10:48
orbeckst pushed a commit to MDAnalysis/PathSimAnalysis that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants