RTD Build Fix #133
Merged
RTD Build Fix #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This same issue won't affect the MDAnalysis main codebase unless the sphinx version is changed I believe |
lilyminium
reviewed
Jul 11, 2024
readthedocs.yaml
Outdated
| @@ -5,7 +5,7 @@ version: 2 | |||
| build: | |||
| os: ubuntu-22.04 | |||
| tools: | |||
| python: "mambaforge-4.10" | |||
| python: "mambaforge-23.11" | |||
There was a problem hiding this comment.
Thanks for the update @ljwoods2, 4.10 is quite old! I worry that old versions could continue to be problematic in the future though, until we reactively update the version in the pins, and doesn't help existing MDAKits. How about switching to mambaforge-latest so it stays up-to-date?
lilyminium
approved these changes
Jul 11, 2024
|
LGTM -- thanks @ljwoods2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132
Changes made in this Pull Request:
PR Checklist