Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI to fail and run appropriately #116

Merged
merged 21 commits into from
May 27, 2024

Conversation

lilyminium
Copy link
Member

@lilyminium lilyminium commented May 25, 2024

Get CI to fail/run as expected

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG.md updated?
  • AUTHORS.md updated?
  • Issue raised/referenced?

@lilyminium lilyminium mentioned this pull request May 25, 2024
5 tasks
@lilyminium
Copy link
Member Author

🎉 ok I think I'm getting the same error I see locally when trying to reproduce #113 #114

@lilyminium lilyminium marked this pull request as ready for review May 26, 2024 11:16
@lilyminium lilyminium changed the title tmp let CI run without codecov Fix CI to fail and run appropriately May 26, 2024
@lilyminium lilyminium changed the base branch from main to decouple-latest-and-dev-testing May 27, 2024 02:16
@lilyminium lilyminium merged commit 0abac8a into decouple-latest-and-dev-testing May 27, 2024
1 check was pending
@lilyminium lilyminium deleted the fix-installation-woes branch May 27, 2024 02:18
lilyminium added a commit that referenced this pull request May 27, 2024
* check tests fail

* update job name

* reset name back to main-tests

* rm dev

* change python matrix to manual

* is codecov the problem here?

* dont fail ci for codecov

* remove all dynamic python versions

* add codecov token?

* escape braces

* ignore codecov failure?

* upgrade act and allow codecov failure again

* add more comment to CI

* try changing the name of the package

* Revert "try changing the name of the package"

This reverts commit 57050d2.

* assert False

* tmp list directory

* downgrade act?

* rm assert False

* pass secret to act

* add actions workaround for secret

* try oidc?

* give up and try editing file to ignore upload failure

* Revert "rm assert False"

This reverts commit 2601768.

* Revert "Revert "rm assert False""

This reverts commit 51bdcff.

* Fix CI to fail and run appropriately (#116)

* tmp let CI run without codecov

* check directory exists

* make package and repo name markedly different

* tmp add assert False

* fix env value?

* fix path?

* fix var name

* add more listing

* even more listing

* am doofus

* rm some temporary changes

* add list back in

* tmp try fixes to check ci

* tmp simplify matrix

* allow os

* allow mdanalysis versions

* use manual python matrix

* Revert "tmp try fixes to check ci"

This reverts commit 613debe.

* Revert "Revert "tmp try fixes to check ci""

This reverts commit 5133e40.

* Revert "Revert "Revert "tmp try fixes to check ci"""

This reverts commit 38cf157.

* try v4

* bump act action?

* upgrade versions

* why isnt this running?

* reorder os?

* upgrade act all the way

* its called act-latest now?

* oops wrong place

* add p=false

* downgrade codecov back to v4, act back to 0.2.40, see how that goes

* Revert "upgrade versions"

This reverts commit 2ecd7b0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant