Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libuv / simpler curl http #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ChristopherHX
Copy link
Contributor

Why?

  • Newer libcurl versions crashs or stuck at 0% while downloading
  • libuv needs to be compiled from source in minecraft-linux build scripts, removing it make the build process simpler
  • I didn't want to debug the complex http interface and why it doesn't work anymore.
  • Failed http calls called the success handler, lead to unspecfic error reports during the past 2 years

What is changed?

  • libuv dependency removed
  • curl_muli replaced by curl_simple
  • failed http requests due to network errors now contain a descriptive error message from curl
  • public api no longer return a curl handle API CHANGE
  • http_pool removed API CHANGE

I switched minecraft-linux to a fork of gplayapi, while there is a major problem with the orginal http code.

@ChristopherHX ChristopherHX marked this pull request as draft June 13, 2022 18:55
@ChristopherHX ChristopherHX marked this pull request as ready for review June 15, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants