Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename package to DeviceUtils.jl #58

Merged
merged 7 commits into from
Jul 23, 2024
Merged

rename package to DeviceUtils.jl #58

merged 7 commits into from
Jul 23, 2024

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Jul 16, 2024

fixes #51

pulling in changes from #52 to allow codecov token access in buildkite.

the package UUID has also been updated as recommended in the general registry readme.

invalidations failure is expected due to name change.

ext/DeviceUtilsTrackerExt.jl Outdated Show resolved Hide resolved
src/DeviceUtils.jl Outdated Show resolved Hide resolved
src/DeviceUtils.jl Outdated Show resolved Hide resolved
src/DeviceUtils.jl Outdated Show resolved Hide resolved
src/DeviceUtils.jl Outdated Show resolved Hide resolved
test/metal_tests.jl Outdated Show resolved Hide resolved
test/metal_tests.jl Outdated Show resolved Hide resolved
test/metal_tests.jl Outdated Show resolved Hide resolved
test/oneapi_tests.jl Outdated Show resolved Hide resolved
test/oneapi_tests.jl Outdated Show resolved Hide resolved
BREAKING CHANGE: All "Lux" prefixes have been dropped for wider adoption

Co-authored-by: Carlo Lucibello <[email protected]>
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 86.26374% with 25 lines in your changes missing coverage. Please review.

Project coverage is 85.76%. Comparing base (a3c57a6) to head (67478a7).

Files Patch % Lines
ext/DeviceUtilsMetalExt.jl 0.00% 8 Missing ⚠️
ext/DeviceUtilsAMDGPUExt.jl 90.00% 5 Missing ⚠️
ext/DeviceUtilsCUDAExt.jl 91.30% 4 Missing ⚠️
ext/DeviceUtilsTrackerExt.jl 57.14% 3 Missing ⚠️
src/DeviceUtils.jl 91.89% 3 Missing ⚠️
ext/DeviceUtilscuDNNExt.jl 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   86.04%   85.76%   -0.29%     
==========================================
  Files          13       13              
  Lines         301      309       +8     
==========================================
+ Hits          259      265       +6     
- Misses         42       44       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarloLucibello
Copy link
Contributor

@avik-pal do you expect to merge this soon?

@avik-pal
Copy link
Member Author

Yes I will merge and tag. It needs to wait for 3 day approval.

@avik-pal avik-pal merged commit 744c83c into main Jul 23, 2024
15 of 16 checks passed
@avik-pal avik-pal deleted the ap/rename branch July 23, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make this package framework agnostic?
2 participants