refactor: general code cleanups #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/update
branch
3 times, most recently
from
1462e59
to
e53c05a
Compare
avik-pal
force-pushed
the
ap/update
branch
2 times, most recently
from
5bd236f
to
ecad149
Compare
avik-pal
force-pushed
the
ap/update
branch
2 times, most recently
from
e21991e
to
36078ef
Compare
avik-pal
force-pushed
the
ap/update
branch
2 times, most recently
from
e4a34a9
to
db0d1b4
Compare
avik-pal
force-pushed
the
ap/update
branch
2 times, most recently
from
635eaad
to
3ec79df
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
===========================================
- Coverage 77.90% 49.51% -28.39%
===========================================
Files 25 23 -2
Lines 783 729 -54
===========================================
- Hits 610 361 -249
- Misses 173 368 +195 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
get_device_typeinside performance-sensitive code instead ofget_deviceForwardDiff.jlis now a main dependency. Needed for some of the future performance improvements that are planned.Needs
get_device_typeMLDataDevices.jl#54