Skip to content

Commit

Permalink
shortcuts: fix file removal - do not remove /dev/null
Browse files Browse the repository at this point in the history
as a non-root user, this would be fine.

but, i was setting up a docker container for development [1], and upon
running a login shell, the shortcuts script would get invoked,
and would remove /dev/null (and later re-create it), which changes its
type from a character device into a regular file, thus breaking the
system (e.g. apt update wouldn't work anymore).

[1] https://github.com/kiprasmel/infra/blob/master/local/devel-core-git/Dockerfile
  • Loading branch information
kiprasmel committed Mar 20, 2024
1 parent 7a96fb1 commit f36e40f
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .local/bin/shortcuts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ fish_shortcuts="/dev/null"
vifm_shortcuts="/dev/null"

# Remove, prepare files
rm -f "$lf_shortcuts" "$ranger_shortcuts" "$qute_shortcuts" "$zsh_named_dirs" "$vim_shortcuts" 2>/dev/null
for file in "$lf_shortcuts" "$ranger_shortcuts" "$qute_shortcuts" "$zsh_named_dirs" "$vim_shortcuts"; do
test -f "$file" && rm -f "$file" 2>/dev/null
done

printf "# vim: filetype=sh\\n" > "$fish_shortcuts"
printf "# vim: filetype=sh\\nalias " > "$shell_shortcuts"
printf "\" vim: filetype=vim\\n" > "$vifm_shortcuts"
Expand Down

0 comments on commit f36e40f

Please sign in to comment.