Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added full Newline remote #579

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Added full Newline remote #579

merged 5 commits into from
Oct 5, 2023

Conversation

Katchowski
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 Linter Result

TVs/Enseo/Enseo_full.ir [4 issues]

# Line 10:
- name: Vol +
        ^^^^^
@@ recommended name 'Vol_up' (WIP) @@

(suggestion): name: Vol_up

# Line 16:
- name: Vol -
        ^^^^^
@@ recommended name 'Vol_dn' (WIP) @@

(suggestion): name: Vol_dn

# Line 28:
- name: Ch +
        ^^^^
@@ recommended name 'Ch_next' (WIP) @@

(suggestion): name: Ch_next

# Line 34:
- name: Ch -
        ^^^^
@@ recommended name 'Ch_prev' (WIP) @@

(suggestion): name: Ch_prev


@Katchowski
Copy link
Contributor Author

Added a full Enseo remote at a later date

@Katchowski
Copy link
Contributor Author

You guys should accept

Vol +
Vol -
Ch +
Ch -

@UberGuidoZ
Copy link
Collaborator

You guys should accept

Vol + Vol - Ch + Ch -

The reason it does not is because of the universal remotes - Flipper Official has hard-coded what it works with. By having it match, it's MUCH faster (and possible to automate) the process of adding new devices into the universal remote settings.

@UberGuidoZ UberGuidoZ merged commit 356547d into Lucaslhm:main Oct 5, 2023
1 check passed
UberGuidoZ pushed a commit that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants