adding tmt #1
Open
adding tmt #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/packit test |
ptoscano
force-pushed
the
packit
branch
2 times, most recently
from
401a966
to
39a16fb
Compare
ptoscano
force-pushed
the
packit
branch
21 times, most recently
from
976e01e
to
eccb06a
Compare
Signed-off-by: Jan Stavel <[email protected]>
Signed-off-by: Jan Stavel <[email protected]>
Signed-off-by: Jan Stavel <[email protected]>
* Drop Go 1.16 from testing matrix * Added Go 1.20 to the same matrix * Note: The RHEL7.9 uses Go 1.19 and the latest Fedora uses 1.20
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.0.0-20210615035016-665e8c7367d1 to 0.1.0. - [Commits](https://github.com/golang/sys/commits/v0.1.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
* Card ID: RHELPLAN-164718 * Checking of issues using shell script analysis tool shellcheck should be without any issue now. * Note: current version of bash auto-complete script provided by urfave package looks little bit different, but it is not compatible with rhc for some reason.
This commits fixes the insights-connection status when it is not connected. Now it shows false when printing in the json format. Signed-off-by: Alba Hita Catala <[email protected]>
Lorquas
commented
Nov 7, 2023
Lorquas
commented
Nov 7, 2023
integration-tests/test_rhc.py
Outdated
|
|
||
| with subtests.test(msg="RHC disconnect"): | ||
| proc = rhc.disconnect() | ||
| proc_stdout = proc.stdout.decode() |
There was a problem hiding this comment.
you assign proc_stdout but never use it?
Lorquas
commented
Nov 7, 2023
integration-tests/test_rhc.py
Outdated
| ... it will disconnect from all Red Hat services | ||
| ... it will inform a user how it goes | ||
| """ | ||
| def test_rhc_connect_disconnect(external_candlepin, test_config, rhc, subtests): |
There was a problem hiding this comment.
Test for activation-key?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.