Code cleanup.

Lombiq · Jul 9, 2023 · 718d036 · 718d036
1 parent 4c88d4f
commit 718d036
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/Lombiq.HelpfulLibraries.OrchardCore/TagHelpers/EditorFieldSetTagHelper.cs b/Lombiq.HelpfulLibraries.OrchardCore/TagHelpers/EditorFieldSetTagHelper.cs
@@ -85,8 +85,8 @@ private void AppendInputAndLabel(TagHelperOutput output, bool isRequired)
             htmlAttributes: null);
 
         var attributes = new Dictionary<string, object>();
-        if (IsReadOnly) attributes["readonly"] = "readonly";
-        if (isRequired) attributes["required"] = "required";
+        AddBoolAttribute(attributes, IsReadOnly, "readonly");
+        AddBoolAttribute(attributes, isRequired, "required");
 
         if (InputType.EqualsOrdinalIgnoreCase("checkbox"))
         {
@@ -168,5 +168,11 @@ private static bool HasRequiredAttribute(ModelExpression modelExpression) =>
             .GetCustomAttributes(typeof(RequiredAttribute), inherit: false)
             .FirstOrDefault() is RequiredAttribute;
 
-    private static void MakeRequired(TagBuilder tagBuilder) => tagBuilder.Attributes.Add("required", "required");
+    private static void AddBoolAttribute(IDictionary<string, object> attributes, bool value, string attributeName)
+    {
+        if (value)
+        {
+            attributes[attributeName] = attributeName;
+        }
+    }
 }