Clean up unreachable code.

Lombiq · Oct 17, 2023 · c4a8611 · c4a8611
1 parent cbe8751
commit c4a8611
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/BitMask/BitMask.cs b/BitMask/BitMask.cs
@@ -431,7 +431,7 @@ public ushort LengthOfRunOfBits(ushort startingPosition)
             length++;
         }
 
-        return (length > startingPosition) ? startingPosition : length;
+        return Math.Min(length, startingPosition);
     }
 
     /// <summary>

diff --git a/Posit/Posit32.cs b/Posit/Posit32.cs
@@ -68,7 +68,7 @@ public Posit32(Quire q)
     {
         PositBits = NaNBitMask;
         var sign = false;
-        var positionOfMostSigniFicantOne = 511;
+        var positionOfMostSignificantOne = 511;
         var firstSegment = (ulong)(q >> (QuireSize - 64));
         if (firstSegment >= 0x_8000_0000_0000_0000)
         {
@@ -81,24 +81,14 @@ public Posit32(Quire q)
         while (firstSegment < 0x_8000_0000_0000_0000)
         {
             q <<= 1;
-            positionOfMostSigniFicantOne -= 1;
+            positionOfMostSignificantOne--;
             firstSegment = (ulong)(q >> (QuireSize - 64));
         }
 
-        var scaleFactor = positionOfMostSigniFicantOne - 240;
-        if (positionOfMostSigniFicantOne == 0)
-        {
-            PositBits = 0;
-            return;
-        }
+        var scaleFactor = positionOfMostSignificantOne - 240;
 
         var resultRegimeKValue = scaleFactor / (1 << MaximumExponentSize);
         var resultExponentBits = (uint)(scaleFactor % (1 << MaximumExponentSize));
-        if (resultExponentBits < 0)
-        {
-            resultRegimeKValue -= 1;
-            resultExponentBits += 1 << MaximumExponentSize;
-        }
 
         PositBits = AssemblePositBitsWithRounding(sign, resultRegimeKValue, resultExponentBits, (uint)(q >> (QuireSize - 32)));
     }