Don't use Floats to parse "extended" Time Spans #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryZe
added
bug
CryZe
force-pushed
the
days-in-time-span-no-floats
branch
from
31ac1a6
to
48b099e
Compare
When parsing the splits files we still accidentally used floats to parse the extended notation that contains the number of days. It really only was used for the amount of days and as far as I can tell never allowed for any fractional values anyways. However, it almost certainly allowed values such as `NaN` or `Inf`, which probably would've caused a panic.
CryZe
force-pushed
the
days-in-time-span-no-floats
branch
from
48b099e
to
e1beec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing the splits files we still accidentally used floats to parse the extended notation that contains the number of days. It really only was used for the amount of days and as far as I can tell never allowed for any fractional values anyways. However, it almost certainly allowed values such as
NaNorInf, which probably would've caused a panic.