Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cosmic-text requirement from 0.10.0 to 0.11.1 #771

Closed
wants to merge 1 commit into from
Closed

Update cosmic-text requirement from 0.10.0 to 0.11.1 #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ image = { version = "0.24.0", features = [
# Currently doesn't require any additional dependencies.

# Default Text Engine
cosmic-text = { version = "0.10.0", default-features = false, features = [
cosmic-text = { version = "0.11.2", default-features = false, features = [
"no_std",
], optional = true }

Expand Down
8 changes: 7 additions & 1 deletion src/rendering/default_text_engine/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,13 @@ impl<P: SharedOwnership> TextEngine<P> {

label.glyphs.clear();

// FIXME: Look into shape plans in 0.11
// FIXME: Look into shape run caches. The problem is that we do fairly
// high quality caching ourselves, which means that we don't hit the
// cache unless something actually changes... however that doesn't mean
// we want to collect "everything". Additionally how many "frames" do we
// want to keep stuff alive even? Doesn't that also heavily depend on
// the frame rate? We don't even have a notion of a frame rate. Should
// we just run it every N label updates instead?
let shape_line = ShapeLine::new_in_buffer(
&mut self.shape_buffer,
&mut self.font_system,
Expand Down
Loading