Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added web-ext --ignore-files option to args to ignore npm or yarn related files in firefox.js #6

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added web-ext --ignore-files option to args to ignore npm or yarn related files in firefox.js #6

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d6e55b8
Update firefox.js
gkrishnaks Jun 8, 2018
c5997a0
Update firefox.js
gkrishnaks Jun 8, 2018
e496d2b
Added --ignore-files to Opera script
gkrishnaks Jun 13, 2018
63c8cc1
Update opera.js
gkrishnaks Jun 13, 2018
32b33fa
Moved --ignore-files to the end of args array
gkrishnaks Jun 13, 2018
b50d3c4
Corrected the pattern list as comma separated
gkrishnaks Jul 29, 2018
05288d6
Update opera.js
gkrishnaks Jul 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/firefox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ module.exports = async function (source) {
'sign',
'--source-dir', source,
'--api-key', process.env.WEXT_SHIPIT_FIREFOX_JWT_ISSUER,
'--ignore-files', '.api-key package.json package-lock.json yarn.lock .npmrc .yarnc',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that .api-key is a standardized file name 🤔 what's the rationale for including it here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
It's an example from Mozilla MDN reference documentation https://developer.mozilla.org/en-US/Add-ons/WebExtensions/web-ext_command_reference#Global_options

(Looks like some people do store their keys in a file of format "filename.api-key" )

However, I tried my changes from my gitlab and it didn't consider ignore-files option.. I raised an issue regarding that - it didn't seem to work when you call it within nodejs script. mozilla/web-ext#1333

In an earlier issue there mozilla/web-ext#843 , they did add ignore-files support for 'sign' - but that doesn't seem to pick for when you call it programmatically.. I guess "web-ext sign" from a CLI might work with ignore-files after that fix which they closed.

'--api-secret', process.env.WEXT_SHIPIT_FIREFOX_JWT_SECRET
]

Expand Down