Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ota apps #477

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Ota apps #477

merged 2 commits into from
Nov 23, 2023

Conversation

mwasilew
Copy link
Contributor

Fix OTA signal handling and add a test for OTA update of docker apps.

Copy link
Collaborator

@nareshkamboju nareshkamboju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

automated/linux/ota-update/download-update.sh Outdated Show resolved Hide resolved
@@ -1,4 +1,4 @@
#!/bin/bash -e

echo "${MESSAGE}" > /var/sota/ota.signal
echo "${MESSAGE}" >> /var/sota/ota.signal
echo "${RESULT}" > /var/sota/ota.result
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be '>>' to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RESULT is not used in the scripts, so it doesn't really matter.

#!/bin/bash -e

echo "${MESSAGE}" >> /var/sota/ota.signal
echo "${RESULT}" >> /var/sota/ota.result
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be '>>' or '>' ?
This file is the same across all ota-rollback, ota-update and ota-apps.
Can it be the same file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can, and it would be preferred. Any ideas where to move this file? My original idea was that each test directory is self contained. Sharing files would break it, but in this instance it makes sense. Some suggestions are more than welcome.

automated/linux/ota-apps/update-apps.sh Show resolved Hide resolved
automated/linux/ota-apps/update-apps.sh Outdated Show resolved Hide resolved
automated/linux/ota-apps/update-apps.sh Outdated Show resolved Hide resolved
reboot_command = "/bin/true"
[pacman]
callback_program = "/var/sota/aklite-callback.sh"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this file be the same all across the different ota-rollback, ota-update and ota-apps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with aklite-callback.sh. This is a shared file, but I don't know how to use it in all test dirs.

Sometimes signal duration is shorter than the wait time in the script.
This patch ensures all signals are registered. Since the tests are
looking for 1st occurance of the signal, there should not be issues with
signals happening more than once.

Signed-off-by: Milosz Wasilewski <[email protected]>
Add a test for OTA update of docker apps. This is slightly different to
OS OTA update as it usually doesn't require a reboot and can be tested
with a single LAVA test acition.

Signed-off-by: Milosz Wasilewski <[email protected]>
@roxell roxell merged commit e5fdc4f into Linaro:master Nov 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants