Merge pull request #161 from Limmen/dev

Update type hints metastorefacade
Limmen · Aug 10, 2023 · e5c33ba · e5c33ba
2 parents 055a907 + 41bc450
commit e5c33ba
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/simulation-system/libs/csle-common/src/csle_common/metastore/metastore_facade.py b/simulation-system/libs/csle-common/src/csle_common/metastore/metastore_facade.py
@@ -57,7 +57,7 @@ def list_emulations() -> List[EmulationEnvConfig]:
                 return records
 
     @staticmethod
-    def list_emulations_ids() -> List[Tuple]:
+    def list_emulations_ids() -> List[Tuple[int, str]]:
         """
         :return: A list of emulation ids in the metastore
         """
@@ -67,7 +67,7 @@ def list_emulations_ids() -> List[Tuple]:
                              f"{constants.METADATA_STORE.HOST_PROPERTY}={constants.METADATA_STORE.HOST}") as conn:
             with conn.cursor() as cur:
                 cur.execute(f"SELECT id,name FROM {constants.METADATA_STORE.EMULATIONS_TABLE}")
-                records = cur.fetchall()
+                records: List[Tuple[int, str]] = cur.fetchall()
                 return records
 
     @staticmethod
@@ -124,7 +124,7 @@ def list_simulations() -> List[SimulationEnvConfig]:
                 return records
 
     @staticmethod
-    def list_simulation_ids() -> List[Dict]:
+    def list_simulation_ids() -> List[Tuple[str, int]]:
         """
         :return: A list of simulation ids and names in the metastore
         """
@@ -134,7 +134,7 @@ def list_simulation_ids() -> List[Dict]:
                              f"{constants.METADATA_STORE.HOST_PROPERTY}={constants.METADATA_STORE.HOST}") as conn:
             with conn.cursor() as cur:
                 cur.execute(f"SELECT id,name FROM {constants.METADATA_STORE.SIMULATIONS_TABLE}")
-                records = cur.fetchall()
+                records: List[Tuple[str, int]] = cur.fetchall()
                 return records
 
     @staticmethod
@@ -476,7 +476,7 @@ def list_emulation_statistics() -> List[EmulationStatistics]:
                 return records
 
     @staticmethod
-    def list_emulation_statistics_ids() -> List[Tuple]:
+    def list_emulation_statistics_ids() -> List[Tuple[int, str]]:
         """
         :return: A list of emulation statistics ids in the metastore
         """
@@ -486,7 +486,7 @@ def list_emulation_statistics_ids() -> List[Tuple]:
                              f"{constants.METADATA_STORE.HOST_PROPERTY}={constants.METADATA_STORE.HOST}") as conn:
             with conn.cursor() as cur:
                 cur.execute(f"SELECT id,emulation_name FROM {constants.METADATA_STORE.EMULATION_STATISTICS_TABLE}")
-                records = cur.fetchall()
+                records: List[Tuple[int, str]] = cur.fetchall()
                 return records
 
     @staticmethod