Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Chairmarks.DEFAULTS.seconds #121

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Support Chairmarks.DEFAULTS.seconds #121

wants to merge 4 commits into from

Conversation

LilithHafner
Copy link
Owner

Implements and closes #71 by providing a global default mechanism: Chairmarks.DEFAULTS.seconds = 1.

@LilithHafner LilithHafner added the enhancement New feature or request label Sep 14, 2024
@LilithHafner
Copy link
Owner Author

RegressionTests found that ttfx_excl_load_time nearly doubles from about 120ms to 180ms.

@LilithHafner
Copy link
Owner Author

Worth considering how this behaves when DEFAULTS.seconds and DEFAULTS.samples are both set, keeping in mind the default behavior of 10x-ing seconds when samples is set.

@LilithHafner
Copy link
Owner Author

Maybe we should stop multiplying runtime budget by 10 when when samples is specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discussion] Global settings/defaults
1 participant
@LilithHafner