Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Phi 3 128k model #1800

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Add Phi 3 128k model #1800

merged 3 commits into from
Oct 23, 2024

Conversation

deveworld
Copy link
Contributor

@deveworld deveworld commented Oct 23, 2024 •
edited by rasbt
Loading

Fixes #1739

I think it's going to work

rasbt
rasbt approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@rasbt rasbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@rasbt rasbt merged commit 7822701 into Lightning-AI:main Oct 23, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasbt rasbt rasbt approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support 128k token version of Phi 3
2 participants
@deveworld @rasbt