-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tools/download-cleaner #8279
base: master
Are you sure you want to change the base?
Conversation
d3ddaaf
to
d94b98f
Compare
This should be ready to replace tools/download-cleaner. The two features I didn't re-implement were downloading the current source tarball for an outdated package, and building a new sources directory. Fetching outside of a build is a repeat of tools/download-tool (though it looks like it could use some attention), or this can be extended at a later date to replace that too. Building a new sources dir was intended as a scriptable workaround for wanting source tarballs to multiple builds. Should no longer be needed. The full list of builds (see L42) could use a second look. I thought there were more aarch64 builds. |
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
Signed-off-by: Ian Leonard <[email protected]>
72ee880
to
87a1d51
Compare
Added Switched more of builds_all over to aarch64. |
Signed-off-by: Ian Leonard <[email protected]>
This replaces tools/download-cleaner with tools/download-cleaner.py. Their intended purpose is the same, but the previous bash script had limitations. The main one is that it was cumbersome in considering multiple project/device/arches.
The replacement may consider all project/device/arch combinations (see builds_all), a limited portion of those with build directories (build.LibreELEC-RPi2.arm...), or the single build specified by PROJECT=X DEVICE=Y ARCH=Z ./download-cleaner.py. Each build combination takes around 30s to consider what packages are needed, so running --all by itself is around 30 minutes.
The way it works it by:
By default, it only prints out what it would remove.
scripts/genbuildplan.py is extended with two additional CLI options to assist with this:
--hide-header
prevents printing the statistics header in the output--list-packages
has it output only a list of packages - no depends or build stepsWork in progress because it doesn't consider packages removed from the tree yet. I'll add a commit to drop tools/download-cleaner when this replacement is ready. Probably still useful to someone else in the meantime, so sharing.