-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#43 Patch to fix intensity/altitude issue (auto max) #78
base: gh-pages
Are you sure you want to change the base?
Conversation
This patch works by automatically setting the max as it changes on each zoom level as points get combined/separated. You no longer need to manually set options.max When calculating the max value it considers all points (even if they are off the screen). This way you always get the same results at a particular zoom level. Thanks to @spacemansteve for pointing me in the right direction ca1f430
Any update on this? It would be nice to see it included. The pull request works perfectly here. |
Bumping this, would appreciate some update here. |
Any update on this? Need this working ! |
I strongly suggest a disclaimer in the readme explaining this bug if it is not going to be be covered. This is a major bug |
This pull request is a must have! I am using it and it is much more intuitive to use the heatmaps when the intensity adjusts based on the current zoom. This really deserves to be merged, even after all this time. |
It's been almost 3 and 1/2 years. Any plans on merging this in? |
At this point it might be worthwhile seeing if anyone else might want to manage this plugin whilst being active? |
Can this PR be approved? |
Please approve this PR, this is a major bug that needs to be fixed. |
@mourner do you have a chance to have a quick check ? I've tested it on uMap and it seems to have more friendly results. The implemented change seems logic to me, but I can't say I master the topic, so a check from you would help! And if it's good for you, I'm up for releasing :) Thanks in advance, and take care, amigo! |
Patch comes from Leaflet/Leaflet.heat#78 We'll remove it when this PR get merged and released.
This patch works by automatically setting the max as it changes on each zoom level as points get combined/separated.
You no longer need to manually set options.max
When calculating the max value it considers all points (even if they are off the screen). This way you always get the same results at a particular zoom level.
Thanks to @spacemansteve for pointing me in the right direction
ca1f430