--find-stale-pods and --correct-stale-pod
#132
Merged
+485
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpsanant
reviewed
Aug 17, 2024
gpsanant
reviewed
Aug 17, 2024
gpsanant
reviewed
Aug 17, 2024
gpsanant
reviewed
Aug 17, 2024
wadealexc
reviewed
Aug 20, 2024
wadealexc
reviewed
Aug 20, 2024
seanmcgary
approved these changes
Aug 20, 2024
gpsanant
reviewed
Aug 20, 2024
| "github.com/pkg/errors" | ||
| ) | ||
|
|
||
| func PodManagerContracts() map[uint64]string { |
There was a problem hiding this comment.
u can prob just do a compile time map declaration? https://github.com/Layr-Labs/eigenlayer-backend/blob/8bf03057b8eea6b5ee186b9907fb71b3e65aba85/common/utils/webappconfigs.go#L60
gpsanant
reviewed
Aug 20, 2024
gpsanant
reviewed
Aug 20, 2024
gpsanant
reviewed
Aug 20, 2024
gpsanant
reviewed
Aug 20, 2024
| podAddress := executionWithdrawalAddress(validator.Validator.WithdrawalCredentials) | ||
| if podAddress != nil { | ||
| slashedEigenpods[*podAddress] = append(slashedEigenpods[*podAddress], validator) | ||
| validatorToPod[validator.Index] = *podAddress |
There was a problem hiding this comment.
u could just reuse withdrawalAddressesToCheck here?
gpsanant
reviewed
Aug 20, 2024
gpsanant
reviewed
Aug 20, 2024
gpsanant
reviewed
Aug 20, 2024
gpsanant
approved these changes
Aug 20, 2024
jbrower95
force-pushed
the
jb/pepe-healthcheck
branch
from
4a0d1e2
to
8efc429
Compare
jbrower95
force-pushed
the
jb/pepe-healthcheck
branch
from
8efc429
to
4ac29f7
Compare
wadealexc
reviewed
Aug 20, 2024
|
|
||
| allActiveSlashedValidatorsBelongingToEigenpods := aFilter(allSlashedValidatorsBelongingToEigenpods, func(validator ValidatorWithIndex) bool { | ||
| validatorInfo := allValidatorInfo[validator.Index] | ||
| return validatorInfo.Status == 1 |
There was a problem hiding this comment.
Should probably reuse utils.ValidatorStatusActive here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new two commands to the CLI --
--find-stale-podsand--correct-stale-pod.--find-stale-pods- This will traverse the beacon state and look for any nodes who have been slashed, s.t their execution balance is now 5% greater than the total sum of their beacon balances. This essentially indicates that you should checkpoint this node again (or, as an external party, invoke
verifyStaleBalances()).- This command reports back all the data in JSON by default. If using
--verboseyou can get a non-JSON view with additional log messages.--correct-stale-pod- Now that you've used the previous command to identify all of the eigenpods who have stale balances, you can use
--corect-stale-podto force the pod to start a new checkpoint! The flow looks like this:- If the pod in question has a checkpoint in progress, the CLI will attempt to complete it by generating proofs and invoking
verifyCheckpointProofs.- The CLI will otherwise/then attempt to start a new checkpoint, using the
EigenPod.verifyStaleBalances()method. This onchain function requires a credential proof targeting the slashed validator, and starts a new checkpoint on the pod.We'll be running these at EigenLabs, to keep the execution balances in sync with beacon balances for pods.