-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rewards v2 #315
Open
0xrajath
wants to merge
5
commits into
dev
Choose a base branch
from
feat/rewards-v2-functions
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Rewards v2 #315
+305
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrajath
commented
Oct 28, 2024
@@ -4,7 +4,7 @@ | |||
[submodule "lib/eigenlayer-contracts"] | |||
path = lib/eigenlayer-contracts | |||
url = https://github.com/Layr-labs/eigenlayer-contracts | |||
branch = dev | |||
branch = feat/rewards-v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be changed and git submodule updated once the upstream changes in eigenlayer-contracts
are merged to dev
. Tracking in Layr-Labs/eigenlayer-contracts#837
0xrajath
commented
Oct 28, 2024
0xrajath
commented
Oct 29, 2024
0xrajath
force-pushed
the
feat/rewards-v2-functions
branch
from
October 29, 2024 20:07
a39419d
to
315bfb1
Compare
0xrajath
commented
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of the Rewards v2 release, we need to support the following features in middleware:
Depends on Layr-Labs/eigenlayer-contracts#837
Modifications
eigenlayer-contracts
dependency to match Rewards v2.ServiceManagerBase
,ECDSAServiceManagerBase
andIServiceManager
:createAVSPerformanceRewardsSubmission
function for AVS to submit performance-based rewards.setClaimerFor
function for AVS to assign claimer on its behalf incase of funds being refunded to the AVS.RewardsCoordinatorMock
in test to implement new functions.TODO
eigenlayer-contracts
upstream changes and update Mock accordingly.Result
Rewards v2 release.