Initialization Fixes

Reimplemented Game Name and Version in Console Window Name
Fixed an issue with Console and Logger methods throwing an error when Console hasn't initialized yet
Fixed an issue with AsmResolver update breaking several usages in ML
Improved Unity Version parsing

MelonLoader/Core.cs

@@ -52,11 +52,12 @@ internal static int Initialize()
             Fixes.DotnetLoadFromManagedFolderFix.Install();
             Fixes.UnhandledException.Install(AppDomain.CurrentDomain);
             Fixes.ServerCertificateValidation.Install();
-
-            MelonUtils.Setup(AppDomain.CurrentDomain);
-
             Assertions.LemonAssertMapping.Setup();
 
+            MelonUtils.Setup(AppDomain.CurrentDomain);
+            BootstrapInterop.SetDefaultConsoleTitleWithGameName(UnityInformationHandler.GameName, 
+                UnityInformationHandler.GameVersion);
+
             try
             {
                 if (!MonoLibrary.Setup()

MelonLoader/InternalUtils/MelonStartScreen.cs

@@ -1,7 +1,7 @@
 using System.IO;
+using AssetRipper.VersionUtilities;
 using MelonLoader.Modules;
 using MelonLoader.Utils;
-using UnityVersion = AssetRipper.Primitives.UnityVersion;
 
 namespace MelonLoader.InternalUtils
 {

MelonLoader/InternalUtils/UnityInformationHandler.cs

@@ -7,9 +7,9 @@
 using System.Text.RegularExpressions;
 using AssetsTools.NET;
 using AssetsTools.NET.Extra;
-using UnityVersion = AssetRipper.Primitives.UnityVersion;
 using System.Drawing;
 using MelonLoader.Utils;
+using UnityVersion = AssetRipper.VersionUtilities.UnityVersion;
 
 namespace MelonLoader.InternalUtils
 {
@@ -19,22 +19,31 @@ public static class UnityInformationHandler
 
         public static string GameName { get; private set; }
         public static string GameDeveloper { get; private set; }
-        public static UnityVersion EngineVersion { get; private set; } = UnityVersion.MinVersion;
+        public static UnityVersion EngineVersion { get; private set; }
         public static string GameVersion { get; private set; }
 
+        private static UnityVersion TryParse(string version)
+        {
+            UnityVersion returnval = UnityVersion.MinVersion;
+            try 
+            {
+                returnval = UnityVersion.Parse(version); 
+            }
+            catch (Exception ex)
+            {
+                if (MelonDebug.IsEnabled())
+                    MelonLogger.Error(ex);
+                returnval = UnityVersion.MinVersion;
+            }
+            return returnval;
+        }
+
         internal static void Setup()
         {
             string gameDataPath = MelonEnvironment.UnityGameDataDirectory;
 
             if (!string.IsNullOrEmpty(MelonLaunchOptions.Core.UnityVersion))
-            {
-                try { EngineVersion = UnityVersion.Parse(MelonLaunchOptions.Core.UnityVersion); }
-                catch (Exception ex)
-                {
-                    if (MelonDebug.IsEnabled())
-                        MelonLogger.Error(ex);
-                }
-            }
+                EngineVersion = TryParse(MelonLaunchOptions.Core.UnityVersion);
 
             AssetsManager assetsManager = new AssetsManager();
             ReadGameInfo(assetsManager, gameDataPath);
@@ -45,22 +54,12 @@ internal static void Setup()
                 ReadGameInfoFallback();
 
             if (EngineVersion == UnityVersion.MinVersion)
-            {
-                try { EngineVersion = ReadVersionFallback(gameDataPath); }
-                catch (Exception ex)
-                {
-                    if (MelonDebug.IsEnabled())
-                        MelonLogger.Error(ex);
-                }
-            }
+                EngineVersion = ReadVersionFallback(gameDataPath);
 
             if (string.IsNullOrEmpty(GameDeveloper))
                 GameDeveloper = DefaultInfo;
             if (string.IsNullOrEmpty(GameName))
                 GameName = DefaultInfo;
-
-            //BootstrapInterop.SetDefaultConsoleTitleWithGameName(GameName, GameVersion);
-
             if (string.IsNullOrEmpty(GameVersion))
                 GameVersion = DefaultInfo;
 
@@ -101,7 +100,7 @@ private static void ReadGameInfo(AssetsManager assetsManager, string gameDataPat
                     assetsManager.LoadClassDatabaseFromPackage(instance.file.Metadata.UnityVersion);
 
                 if (EngineVersion == UnityVersion.MinVersion)
-                    EngineVersion = UnityVersion.Parse(instance.file.Metadata.UnityVersion);
+                    EngineVersion = TryParse(instance.file.Metadata.UnityVersion);
 
                 List<AssetFileInfo> assetFiles = instance.file.GetAssetsOfType(AssetClassID.PlayerSettings);
                 if (assetFiles.Count > 0)
@@ -129,7 +128,6 @@ private static void ReadGameInfo(AssetsManager assetsManager, string gameDataPat
             {
                 if (MelonDebug.IsEnabled())
                     MelonLogger.Error(ex);
-                //MelonLogger.Error("Failed to Initialize Assets Manager!");
             }
             if (instance != null)
                 instance.file.Close();
@@ -170,7 +168,7 @@ private static UnityVersion ReadVersionFallback(string gameDataPath)
             if (Environment.OSVersion.Platform == PlatformID.Win32NT)
             {
                 var unityVer = FileVersionInfo.GetVersionInfo(unityPlayerPath);
-                return new UnityVersion((ushort)unityVer.FileMajorPart, (ushort)unityVer.FileMinorPart, (ushort)unityVer.FileBuildPart);
+                return TryParse(unityVer.FileVersion);
             }
 
             try
@@ -197,7 +195,7 @@ private static UnityVersion ReadVersionFallback(string gameDataPath)
                     MelonLogger.Error(ex);
             }
 
-            return default;
+            return UnityVersion.MinVersion;
         }
 
         private static UnityVersion GetVersionFromGlobalGameManagers(byte[] ggmBytes)
@@ -225,7 +223,7 @@ private static UnityVersion GetVersionFromGlobalGameManagers(byte[] ggmBytes)
                 unityVer = verString.ToString().Trim();
             }
 
-            return UnityVersion.Parse(unityVer);
+            return TryParse(unityVer);
         }
 
         private static UnityVersion GetVersionFromDataUnity3D(Stream fileStream)
@@ -248,7 +246,7 @@ private static UnityVersion GetVersionFromDataUnity3D(Stream fileStream)
                 verString.Append(Convert.ToChar(read));
             }
 
-            return UnityVersion.Parse(verString.ToString().Trim());
+            return TryParse(verString.ToString().Trim());
         }
     }
 }

MelonLoader/Utils/AssemblyVerifier.cs

@@ -1,7 +1,9 @@
 #if NET6_0
 using AsmResolver.DotNet;
 using AsmResolver.PE.DotNet.Metadata;
+using AsmResolver.PE.DotNet.Metadata.Strings;
 using AsmResolver.PE.DotNet.Metadata.Tables;
+using AsmResolver.PE.DotNet.Metadata.Tables.Rows;
 using System;
 using System.Collections.Generic;
 using System.Linq;
@@ -41,7 +43,7 @@ internal static void EnsureInitialized()
             var dummyListToEnsureThisCodeDoesntGetNuked = new List<object>();
 
             //Force load AsmResolver
-            dummyListToEnsureThisCodeDoesntGetNuked.Add(new Constant(AsmResolver.PE.DotNet.Metadata.Tables.ElementType.Class, null));
+            dummyListToEnsureThisCodeDoesntGetNuked.Add(new Constant(ElementType.Class, null));
             dummyListToEnsureThisCodeDoesntGetNuked.Add(typeof(AsmResolver.PE.File.PEFile));
         }
 

MelonLoader/Utils/MelonConsole.cs

@@ -36,9 +36,15 @@ internal static void Init()
         };
     }
 
+    private static bool ShouldNotUseWriter()
+        => (MelonUtils.IsUnderWineOrSteamProton()
+            || !MelonUtils.IsWindows
+            || MelonLaunchOptions.Console.ShouldHide
+            || (ConsoleOutWriter == null));
+
     internal static void WriteLine(string txt)
     {
-        if (MelonUtils.IsUnderWineOrSteamProton() || !MelonUtils.IsWindows || MelonLaunchOptions.Console.ShouldHide)
+        if (ShouldNotUseWriter())
         {
             Console.WriteLine(txt);
             return;
@@ -48,7 +54,7 @@ internal static void WriteLine(string txt)
 
     internal static void WriteLine(object txt)
     {
-        if (MelonUtils.IsUnderWineOrSteamProton() || !MelonUtils.IsWindows || MelonLaunchOptions.Console.ShouldHide)
+        if (ShouldNotUseWriter())
         {
             Console.WriteLine(txt.ToString());
             return;
@@ -58,7 +64,7 @@ internal static void WriteLine(object txt)
 
     internal static void WriteLine()
     {
-        if (MelonUtils.IsUnderWineOrSteamProton() || !MelonUtils.IsWindows || MelonLaunchOptions.Console.ShouldHide)
+        if (ShouldNotUseWriter())
         {
             Console.WriteLine();
             return;