Skip to content

Commit

Permalink
.github/zephyr: disable disassembly with inline source code
Browse files Browse the repository at this point in the history
By default, the disassembly file (.lst) generated
during the build process when enabling `CONFIG_OUTPUT_DISASSEMBLY`
will also contain inline source code. This is not ideal
for reproducible builds that compare the .lst files
obtained on different platforms (i.e: Windows and Linux)
because of the differences in the inline source code that
may appear.

One of the identified causes for such differences were
the ".." include paths, which resulted in the Windows
.lst omitting some bits of the inline source code that
were present in the Linux .lst file.

Because these issues are hard to debug and unintuitive,
the solution is to disable the inline source code. This way,
the CI can keep testing for reproductibility using just the
assembly and machine code from the .lst file, which are
more important than the inline source code.

This fixes thesofproject/issues/9034.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
  • Loading branch information
LaurentiuM1234 committed Apr 22, 2024
1 parent 3cefabf commit 18f2473
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/zephyr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ jobs:
--cmake-args=-DEXTRA_AFLAGS='-Werror -Wa,--fatal-warnings'
--cmake-args=--warn-uninitialized
--cmake-args=-DCONFIG_OUTPUT_DISASSEMBLY=y
--cmake-args=-DCONFIG_OUTPUT_DISASSEMBLY_WITH_SOURCE=n
${{ matrix.build_opts }} ${{ matrix.IPC_platforms }}

- name: Upload build artifacts
Expand Down Expand Up @@ -361,6 +362,7 @@ jobs:
--cmake-args=-DEXTRA_AFLAGS='-Werror -Wa,--fatal-warnings'
--cmake-args=--warn-uninitialized
--cmake-args=-DCONFIG_OUTPUT_DISASSEMBLY=y
--cmake-args=-DCONFIG_OUTPUT_DISASSEMBLY_WITH_SOURCE=n
${{ matrix.build_opts }} ${{ matrix.platforms }}

- name: Upload build artifacts
Expand Down

0 comments on commit 18f2473

Please sign in to comment.