Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add member Megan #59

Merged
merged 9 commits into from
Jun 20, 2023
Merged

Conversation

amandhawb
Copy link
Contributor

Overview

Adding one more Latina Dev! πŸ˜„

Relevant Issue

#57

βœ…οΈ By submitting this PR, I have verified the following

  • Reviewed the contributing guidelines πŸ”οΈ
  • Added my name to the bottom of the list under the Contributors section in the README.md with a link to my personal website or GitHub profile πŸ‘₯️

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
latina-dev βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 15, 2023 8:17pm

@FrancesCoronel
Copy link
Member

Can we remove the change where the analytics component is moved slightly? It's not related and I think prettier would move it back anyways in next diff

@FrancesCoronel
Copy link
Member

Otherwise looks good!

@EllaCodes4
Copy link
Collaborator

Can we remove the change where the analytics component is moved slightly? It's not related and I think prettier would move it back anyways in next diff

Megan's photo looks stretched out on my end. @amandhawb: Can you resize to a 250px square and see if that looks better? The image is rectangular right now and I think that's why it. Thank you!

@amandhawb
Copy link
Contributor Author

Can we remove the change where the analytics component is moved slightly? It's not related and I think prettier would move it back anyways in next diff

Megan's photo looks stretched out on my end. @amandhawb: Can you resize to a 250px square and see if that looks better? The image is rectangular right now and I think that's why it. Thank you!

I resized it @EllaCodes4 , not sure if it changed because of the cache... I am still trying to see how to configure it

public/img/members/megan-rodriguez.jpg Show resolved Hide resolved
data/members/megan-rodriguez-.md Outdated Show resolved Hide resolved
@FrancesCoronel
Copy link
Member

Can we remove the change where the analytics component is moved slightly? It's not related and I think prettier would move it back anyways in next diff

This was done, thank you! Just made two comments on the image + file name.

@FrancesCoronel
Copy link
Member

image is low res but otherwise looks good!

@FrancesCoronel FrancesCoronel merged commit bad2270 into Latina-Dev:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants