Mere support for climateData API #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jeg tilføjede også til ClimateDataParameter som maglede fra listen. Mvh, Per |
|
Jeg tilføjede en "pars" parameter til get_closest_station, så man kan bede om den nærmeste station med specifikke data. Den bruger dog DMI navne, ikke navnene fra enums.py som den måske burde. |
LasseRegin
requested changes
Oct 17, 2021
Co-authored-by: Lasse Regin Nielsen <[email protected]>
Co-authored-by: Lasse Regin Nielsen <[email protected]>
Co-authored-by: Lasse Regin Nielsen <[email protected]>
Co-authored-by: Lasse Regin Nielsen <[email protected]>
Co-authored-by: Lasse Regin Nielsen <[email protected]>
|
Rettet. |
|
Tror jeg. Jeg har stadig ikke lært hvordan github fungerer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hej Lasse.
Tak for et nyttigt stykke kode.
Jeg prøvede at kalde get_stations med en client åbnet med en "climateData"api key, det virkede ikke da get_stations er hardkodet til "metObs" api. Jeg tror ikke man kan blande api key og api, så måske giver det mest mening at gemme navnet på api'en sammen med key i client datastrukturen?
Mvh,
Per