chore: Disable bloom filtering for bounded sharding strategy (grafana…

…#14272) This commit temporarily disables bloom filtering chunk refs in the `GetShards()` call on the index gateway when using the `bounded` sharding strategy. This will result in chunks only being filtered once by the bloom gateway, reducing the amount of checks that need to be done on the bloom filters for a single request.Signed-off-by: Christian Haudum <[email protected]>
LashaJini · Sep 26, 2024 · 86d4316 · 86d4316
1 parent cfc488a
commit 86d4316
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/pkg/indexgateway/gateway.go b/pkg/indexgateway/gateway.go
@@ -413,7 +413,7 @@ func (g *Gateway) GetShards(request *logproto.ShardsRequest, server logproto.Ind
 	return g.boundedShards(ctx, request, server, instanceID, p, forSeries)
 }
 
-// boundedShards handles bounded shard requests, optionally using blooms and/or returning precomputed chunks.
+// boundedShards handles bounded shard requests, optionally returning precomputed chunks.
 func (g *Gateway) boundedShards(
 	ctx context.Context,
 	req *logproto.ShardsRequest,
@@ -466,18 +466,20 @@ func (g *Gateway) boundedShards(
 
 	// 2) filter via blooms if enabled
 	filters := v1.ExtractTestableLabelMatchers(p.Plan().AST)
-	if g.bloomQuerier != nil && len(filters) > 0 {
-		xs, err := g.bloomQuerier.FilterChunkRefs(ctx, instanceID, req.From, req.Through, refs, p.Plan())
-		if err != nil {
-			level.Error(logger).Log("msg", "failed to filter chunk refs", "err", err)
-		} else {
-			filtered = xs
-		}
-		sp.LogKV(
-			"stage", "queried bloom gateway",
-			"err", err,
-		)
-	}
+	// NOTE(chaudum): Temporarily disable bloom filtering of chunk refs,
+	// as this doubles the load on bloom gateways.
+	// if g.bloomQuerier != nil && len(filters) > 0 {
+	// 	xs, err := g.bloomQuerier.FilterChunkRefs(ctx, instanceID, req.From, req.Through, refs, p.Plan())
+	// 	if err != nil {
+	// 		level.Error(logger).Log("msg", "failed to filter chunk refs", "err", err)
+	// 	} else {
+	// 		filtered = xs
+	// 	}
+	// 	sp.LogKV(
+	// 		"stage", "queried bloom gateway",
+	// 		"err", err,
+	// 	)
+	// }
 
 	g.metrics.preFilterChunks.WithLabelValues(routeShards).Observe(float64(ct))
 	g.metrics.postFilterChunks.WithLabelValues(routeShards).Observe(float64(len(filtered)))