-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excluding keys #34
Excluding keys #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this code in our repository, but I've checked the code changed and it looks fine to me.
Thanks! 😁
| This package allows you to check your Laravel translations for missing | ||
| keys, unused keys and unused translations. | ||
| You can ignore some keys by adding them to the 'ignore' array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is the description i used in my PR but currently the package let's you find missing keys but don't have any functionality related to "unused keys/translations". When I opened the PR I just pasted an example description without paying too much attention.
Maybe you can remove that part to better reflect the current functionality of the package.
As a side comment about the code, unrelated to this PR: I saw you use a double I'm reading the code from my phone so maybe I'm missing something but that would make the checking to work 2 levels deep, am I right? Maybe you can use |
Closing as this will be handled in #42 |
Introduces the possibility to exclude keys via config or parameter to the command.