Merge pull request #39 from LarsWiegers/exclude-ds-store

exclude mac files

src/Console/Commands/CheckIfTranslationsAreAllThereCommand.php

@@ -16,7 +16,6 @@ class CheckIfTranslationsAreAllThereCommand extends Command
      * @var string
      */
     protected $signature = 'translations:check {--directory=} {--excludedDirectories=none}';
-
     /**
      * The console command description.
      *
@@ -34,6 +33,8 @@ class CheckIfTranslationsAreAllThereCommand extends Command
      */
     public array $realLines = [];
 
+    const EXCLUDE_MAC_FILES = ['.DS_Store'];
+
     /**
      * Create a new command instance.
      *
@@ -88,6 +89,10 @@ public function handle()
                         continue;
                     }
 
+                    if(in_array($languageWithMissingFile, self::EXCLUDE_MAC_FILES)) {
+                        continue;
+                    }
+
                     $missingFiles[] = 'The language ' . $languageWithMissingFile . ' (' . $directory . '/' . $languageWithMissingFile . ') is missing the file ( ' . $fileName . ' )';
 				}
                 $this->handleFile($languageDir, $langFile);
@@ -118,6 +123,10 @@ public function handle()
                         }
                     }
 
+                    if(in_array($language, self::EXCLUDE_MAC_FILES)) {
+                        continue;
+                    }
+
                     if(Str::contains($fileKey, $languages)) {
                         $missing[] = $language . '.' . $keyWithoutFile;
                     }else {

tests/Tests/Unit/Console/Commands/CheckExcludeMacFilesTest.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace Console\Commands;
+
+use Tests\TestCase;
+
+class CheckExcludeMacFilesTest extends TestCase
+{
+    private string $languagesDir = 'tests/resources/lang/exclude_mac_files';
+    public function setUp(): void
+    {
+        parent::setUp();
+    }
+
+    public function testItSkipsTotallyFineIfDSStoreExists()
+    {
+        $command = $this->artisan('translations:check', [
+            '--directory' => $this->languagesDir . '/ds-store'
+        ]);
+
+        $command->assertExitCode(0);
+    }
+}

tests/resources/lang/exclude_mac_files/ds-store/en/test.php

@@ -0,0 +1,5 @@
+<?php
+
+return [
+    'test_key' => 'test_value',
+];