Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all select option on checklist field #5559

Merged
merged 8 commits into from
Jul 15, 2024

Conversation

pxpm
Copy link
Contributor

@pxpm pxpm commented Jul 12, 2024

This is a super-seed of #3989

I couldn't push to @kamrul-bd branch because his fork was outdated and was missing branches I didn't had permission to create.

This addresses @tabacitu review request on the mentioned PR.

A simple, Select All -> Unselect All anchor in the field, nothing fancy.

image

Docs: Laravel-Backpack/docs#585

@tabacitu
Copy link
Member

I agree with an "Unselect all" if we have a "Select all". Please makes sure it looks good @pxpm - right now in the screenshot it looks like it's smack-down the first thing in the field. Which doesn't make sense, this button is an ACCESSORY, not the first thing a person should see. Don't know where it would make sense. Some ideas:

  • at the very end of all options
  • on the label (pull-right)

@pxpm pxpm force-pushed the add-all-select-option-on-checklist-field branch from 105cf51 to a52589f Compare July 15, 2024 09:01
@pxpm pxpm merged commit 6ec392c into main Jul 15, 2024
8 checks passed
@pxpm pxpm deleted the add-all-select-option-on-checklist-field branch July 15, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants