-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implemented frog selection options #25
- Loading branch information
Showing
3 changed files
with
33 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ | |
|
||
setup( | ||
name = "PICCL", | ||
version = "0.5", | ||
version = "0.5.1", | ||
author = "Martin Reynaert, Maarten van Gompel", | ||
author_email = "[email protected]", | ||
description = ("Webservice for PICCL"), | ||
|
5b77747
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this commit considered stable? It got a new version number in the setup but did not get tagged. I don't know what your tagging policy is but it would be beneficial for the deployment of our test server if this commit got tagged
v0.5.1
.In case it matters, yesterday I ran a test where I think I managed to pin all Piccl's files to this commit's version*, and the Piccl pipeline including frog seemed to work perfectly as far as I can tell 🙂
* LaMachine checked out the commit after this one, but I manually reverted the one file changed in that commit.
5b77747
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I indeed didn't release it yet cause I hadn't tested it extensively yet and there were more changes coming up. But I can do a quick release from this commit if this is a good state for you to test with.
5b77747
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be appreciated! I think LaMachine also has an option to specify a specific (custom) version so I could look into that alternatively.
5b77747
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Released: https://github.com/LanguageMachines/PICCL/releases/tag/v0.5.1
Yeah, that's the plan for LaMachine but that part is not implemented yet. (it wasn't used much in LaMachine v1 so I gave it a lower priority)
5b77747
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks! 😃