Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit-Test Workflows and CodeQL workflows #16

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Conversation

vihar-s1
Copy link
Contributor

@vihar-s1 vihar-s1 commented Oct 6, 2024

Pull Request Overview

Issue Closed #10

Changes

unit-tests.yml workflow

  • Github workflow file for running unit-tests when a new PR is raised, or code is pushed to the main branch

codeql.yml workflow

  • Workflow file for performing static analysis on the codebase for a new PR or a code push to main branch

@vihar-s1
Copy link
Contributor Author

vihar-s1 commented Oct 6, 2024

Sorry for the delay...was pr-occupied with some other task...please tell me if you require some additional changes. @navin772

.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/unit-tests.yml Outdated Show resolved Hide resolved
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.


steps:
- name: Checkout repository
uses: actions/checkout@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use actions/checkout@v4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the action results...will make the fixes/changes to resolve the warnings found in thr run

# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v2
# - run: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove dead code!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had kept it as a guide. If you feel like it, I will remove it.

strategy:
fail-fast: false
matrix:
language: [ "java-kotlin" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to understabd in here. can we have ??

Suggested change
language: [ "java-kotlin" ]
language: [ "java", "kotlin" ]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think so...couldn't find anything exactly matching but it should work.

.github/workflows/unit-tests.yml Show resolved Hide resolved
uses: gradle/actions/setup-gradle@v3

- name: Run test suites
run: ./gradlew test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: ./gradlew test
run: ./gradlew test --info

For logs!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

.github/workflows/unit-tests.yml Show resolved Hide resolved
@vihar-s1
Copy link
Contributor Author

If there are no open issues with the PR, then can you guys get this PR merged? Also, can you please add the hacktoberfest label to this PR?

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harsha509 harsha509 merged commit 7511f8e into LambdaTest:main Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup GitHub Actions for CI on PR and Push Events
3 participants