Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Indium incompatibility #224

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Conversation

BluSpring
Copy link
Contributor

Issues: #185, #212

This PR creates a mixin into Indium's TerrainRenderContext#bufferQuad, making the quad light also use LDL's lightmap values, which solves both:

With the nature of how this mixin works, it unfortunately requires a compile-time dependency on Indium, unless someone can figure out a way to avoid that entirely.

@arsel-5lvxa7b1
Copy link

Hello, what's stopping this PR to get merged? I can help if needed

@LambdAurora LambdAurora merged commit 5ba107a into LambdAurora:1.20.4 Jul 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants