LambDynamicLights 1.3.4: Fix ghost dynamic light sources.

.github/workflows/gradlebuild.yml

@@ -0,0 +1,26 @@
+name: Gradle Build
+
+on:
+  push:
+    branches:
+      - '*'
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up JDK 1.8
+        uses: actions/setup-java@v1
+        with:
+          java-version: 1.8
+          server-id: github # Value of the distributionManagement/repository/id field of the pom.xml
+          settings-path: ${{ github.workspace }} # location for the settings.xml file
+
+      - name: Build with Gradle
+        run: gradle build
+
+      - uses: actions/upload-artifact@v2
+        with:
+          name: Artifacts
+          path: ./build/libs/

CHANGELOG.md

@@ -1,11 +1,11 @@
 # LambDynamicLights changelog
 
-## v1.0.0
+## 1.0.0
 
  - Initial release.
  - Added dynamic lighting to the game.
 
-## v1.1.0
+## 1.1.0
 
  - Added item frame dynamic lighting.
  - Added API.
@@ -20,30 +20,30 @@
  - Fixed light not moving when light source was moving too slow.
  - Fixed lighting errors with Sodium.
 
-## v1.2.0
+## 1.2.0
 
  - Added water-sensitive check for items and light sources.
    - Added data item tag `#lambdynlights:water_sensitive` which lists every item which can't light up in the water.
    - Added an option to enable/disable the feature
- - Updated [SpruceUI] to v1.5.6 to fix latest snapshots issues.
+ - Updated [SpruceUI] to 1.5.6 to fix latest snapshots issues.
  - Added "early/WIP" compatibility with [Canvas Renderer].
    - Added a warning message about performance issues. 
  - Fixed a crash with [Sodium] rc7 with smooth lighting set to HIGH.
 
-### v1.2.1
+### 1.2.1
 
  - Added TNT dynamic lighting.
  - Added lighting options for TNT and Creepers.
  - Added luminance value to Fire charge item.
- - Updated [SpruceUI] to v1.5.8
+ - Updated [SpruceUI] to 1.5.8
  - Fixed player dynamic lighting not getting tracked when changing dimensions.
 
-### v1.2.2
+### 1.2.2
 
  - Changed video options dynamic lighting button to redirect to LambDynamicLights settings.
  - Fixed random crash.
 
-## v1.3.0
+## 1.3.0
 
  - Added Simplified Chinese translations.
  - Added German translations.
@@ -53,18 +53,18 @@
  - Added spectral arrow as item emitting light ([#17](https://github.com/LambdAurora/LambDynamicLights/pull/17)).
  - Added dynamic lighting on glowing entities ([#17](https://github.com/LambdAurora/LambDynamicLights/pull/17)).
  - Updated to Minecraft 1.16.2
- - Updated [SpruceUI] to v1.6.2.
+ - Updated [SpruceUI] to 1.6.2.
  - Fixed dynamic lighting update issues at chunk borders ([#12](https://github.com/LambdAurora/LambDynamicLights/issues/12)).
  - Fixed water-sensitive items lighting up in water on dedicated servers. ([#3](https://github.com/LambdAurora/LambDynamicLights/issues/3))
     - Added new JSON API to add item luminance and water-sensitivity through resource packs.
     - Added `DynamicLightHandler#isWaterSensitive` to make some entities water-sensitive like the blaze.
  - Fixed incompatibility with future [Sodium] versions. ([#6](https://github.com/LambdAurora/LambDynamicLights/issues/6))
 
-## v1.3.1
+### 1.3.1
 
  - Fixed entity lighting issue with [Sodium] 0.1.0. ([#23](https://github.com/LambdAurora/LambDynamicLights/issues/23))
 
-## v1.3.2
+### 1.3.2
 
  - Added entity lighting capabilities to minecarts.
  - Added `DynamicLightsInitializer` and `dynamiclights` entrypoint.
@@ -75,14 +75,20 @@
  - Updated French translations.
  - Fixed memory leak in dynamic light source tracking. ([#30](https://github.com/LambdAurora/LambDynamicLights/issues/30))
 
-# v1.3.3
+### 1.3.3
 
  - Added Italian translations ([#40](https://github.com/LambdAurora/LambDynamicLights/pull/40)).
  - Optimized dynamic lighting update methods.
  - Fixed crash when leaving world with some minimaps mods. ([#37](https://github.com/LambdAurora/LambDynamicLights/issues/37), [#41](https://github.com/LambdAurora/LambDynamicLights/issues/41))
  - Fixed crash with Immersive Portals ([#39](https://github.com/LambdAurora/LambDynamicLights/issues/39)).
  - Updated [SpruceUI], and Fabric API dependencies.
 
+### 1.3.4
+
+ - Fix ghost dynamic light source ([#47](https://github.com/LambdAurora/LambDynamicLights/issues/47)).
+ - Fix missing background in settings screen.
+ - Updated [SpruceUI].
+
 [SpruceUI]: https://github.com/LambdAurora/SpruceUI "SpruceUI page"
 [Sodium]: https://modrinth.com/mod/sodium "Sodium Modrinth page"
 [Canvas Renderer]: https://www.curseforge.com/minecraft/mc-mods/canvas-renderer "Canvas Renderer CurseForge page"

gradle.properties

@@ -8,12 +8,12 @@ yarn_mappings=1.16.5+build.1
 loader_version=0.11.1
 
 # Mod Properties
-mod_version = 1.3.3
+mod_version = 1.3.4
 maven_group = me.lambdaurora
 archives_base_name = lambdynamiclights
 
 # Dependencies
 # currently not on the main fabric site, check on the maven: https://maven.fabricmc.net/net/fabricmc/fabric-api/fabric-api
 fabric_version=0.29.3+1.16
-spruceui_version=2.0.1-1.16
+spruceui_version=2.0.4-1.16
 modmenu_version=1.14.6+build.31

src/main/java/me/lambdaurora/lambdynlights/DynamicLightsConfig.java

@@ -23,11 +23,11 @@
  * Represents the mod configuration.
  *
  * @author LambdAurora
- * @version 1.3.3
+ * @version 1.3.4
  * @since 1.0.0
  */
 public class DynamicLightsConfig {
-    private static final DynamicLightsMode DEFAULT_DYNAMIC_LIGHTS_MODE = DynamicLightsMode.OFF;
+    private static final DynamicLightsMode DEFAULT_DYNAMIC_LIGHTS_MODE = DynamicLightsMode.FANCY;
     private static final boolean DEFAULT_ENTITIES_LIGHT_SOURCE = true;
     private static final boolean DEFAULT_BLOCK_ENTITIES_LIGHT_SOURCE = true;
     private static final boolean DEFAULT_WATER_SENSITIVE_CHECK = true;

src/main/java/me/lambdaurora/lambdynlights/LambDynLights.java

@@ -48,7 +48,7 @@
  * Represents the LambDynamicLights mod.
  *
  * @author LambdAurora
- * @version 1.3.3
+ * @version 1.3.4
  * @since 1.0.0
  */
 public class LambDynLights implements ClientModInitializer {
@@ -372,7 +372,7 @@ public static void scheduleChunkRebuild(@NotNull WorldRenderer renderer, @NotNul
      * @param chunkPos the packed chunk position
      */
     public static void scheduleChunkRebuild(@NotNull WorldRenderer renderer, long chunkPos) {
-        scheduleChunkRebuild(renderer, ChunkSectionPos.unpackX(chunkPos), ChunkSectionPos.unpackY(chunkPos), ChunkSectionPos.unpackZ(chunkPos));
+        scheduleChunkRebuild(renderer, BlockPos.unpackLongX(chunkPos), BlockPos.unpackLongY(chunkPos), BlockPos.unpackLongZ(chunkPos));
     }
 
     public static void scheduleChunkRebuild(@NotNull WorldRenderer renderer, int x, int y, int z) {

src/main/java/me/lambdaurora/lambdynlights/gui/SettingsScreen.java

@@ -29,7 +29,7 @@
  * Represents the settings screen of LambDynamicLights.
  *
  * @author LambdAurora
- * @version 1.3.3
+ * @version 1.3.4
  * @since 1.0.0
  */
 public class SettingsScreen extends SpruceScreen {
@@ -108,6 +108,11 @@ protected void init() {
                 (btn) -> this.client.openScreen(this.parent)));
     }
 
+    @Override
+    public void renderBackground(MatrixStack matrices) {
+        this.renderBackgroundTexture(0);
+    }
+
     @Override
     public void renderTitle(MatrixStack matrices, int mouseX, int mouseY, float delta) {
         drawCenteredText(matrices, this.textRenderer, this.title, this.width / 2, 18, 16777215);