Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make aws as peer dependency #43

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

MartinAndreev
Copy link
Collaborator

Description

As AWS does regular updates on the AWS SDK, and as we plan to release another package, that depends on the SDK, we are moving the SDK as a peer dependency and will release a new major version.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests
  • E2E tests

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@MartinAndreev MartinAndreev added enhancement New feature or request breaking-change labels Jul 25, 2023
@MartinAndreev MartinAndreev self-assigned this Jul 25, 2023
@MartinAndreev MartinAndreev merged commit 10e2b2d into master Jul 25, 2023
1 check passed
@MartinAndreev MartinAndreev deleted the feature/aws-sdk-as-peer-dependencie branch July 25, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant