Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Added timestamp utils to mip sdk #108

Open
wants to merge 186 commits into
base: develop
Choose a base branch
from
Open

[DRAFT] Added timestamp utils to mip sdk #108

wants to merge 186 commits into from
+1,372 −1

Conversation

rafarrel
Copy link
Contributor

@rafarrel rafarrel commented Jun 4, 2024 •
edited
Loading

Resolves MSCLLITE-115. Moved these from the gps time update branch in InertialConnect, as requested. These are generalized utilities that can be used for managing timestamps. They can be added to in the future as well with utilities for new use cases.

To run the test suite:

  • Compile mip_sdk with BUILD_TESTING on.
  • Run: ctest -E "TestMipPacketBuilding|TestMipPerf" --output-on-failure

@rafarrel rafarrel self-assigned this Jun 4, 2024
@rafarrel rafarrel changed the base branch from master to develop June 4, 2024 17:21
msclissa
msclissa requested changes Jun 18, 2024
View reviewed changes
src/mip/utils/timestamp.hpp Outdated Show resolved Hide resolved
src/mip/utils/timestamp.hpp Outdated Show resolved Hide resolved
src/mip/utils/timestamp.hpp Outdated Show resolved Hide resolved
src/mip/utils/timestamp.hpp Outdated Show resolved Hide resolved
src/mip/utils/timestamp.hpp Outdated Show resolved Hide resolved
src/mip/utils/timestamp.hpp Outdated Show resolved Hide resolved
src/mip/utils/timestamp.hpp Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
src/mip/utils/timestamp.hpp Outdated Show resolved Hide resolved
src/mip/utils/timestamp.hpp Outdated Show resolved Hide resolved
@rafarrel
Removed Months from timestamp utils
e709c09
@rafarrel
Changed private member variable name
c3ffef2
@rafarrel
Removed symmetric example
ca90ef3
@rafarrel
Removed trailing space
6d14e38
@rafarrel
Moved timestamp functions back into class and renamed class to Timest…
76f2279 
…ampManager
@rafarrel
Renamed file to timestamp_manager
fac0aac
@rafarrel
Added blank test for timestamp manager and commented out failing/stal…
d155d7c 
…ling tests
@rafarrel
Added failing tests back
c5227e5
@rafarrel
Added test case skeletons for getTimestamp
2a369f5
@rafarrel
Added test for getTimestamp (template base)
ffc73c1
@rafarrel
Refactored getTimestamp test
81a4b3b
@rafarrel
Implemented test for getTimestamp template function (currently failing)
83bd4d3
@rafarrel
Added failure output for base function getTimestamp tests
c656353
@rafarrel
Added generalized testCase function for timestamp type tests
777addf
@rafarrel
Revampled testCase functions
0fdf0f2
@rafarrel
Refactored test with new testCase function interface
3a7404b
@rafarrel
Fixed faulty test for GetTimestamp-value
caa80a8
@rafarrel
Organized utility functions
e28fd31
@rafarrel
Moved convertFrom and castTime to misc.hpp
2884bad
@rafarrel
Restructured castTime tests for new interface (failing)
be1314d
@rafarrel
Re-designed tests for convert for new interface
b9a8a77
@rafarrel
Implemented new versions for convert and castTime (passing)
fc7e27d
@rafarrel
Removed unnecessary getTimestampBaseStandard method
d745734
@rafarrel
Hopefully fixed std::invalid_argument error in build on jenkins?
d931c94
@rafarrel
Updated main timestamp class documentation, constructor documentation…
0462d78 
…, and synchronize documentation
@rafarrel
Updated documentation for increment and add exception throw documenta…
2f0b632 
…tion for constructor
@rafarrel
Updated documentation for setWeek
2e7103f
@rafarrel
Updated documentation for setTimeOfWeek
c030fff
@rafarrel
Removed unnecessary examples from setWeek and setTimeOfWeek documenta…
651447d 
…tion
@rafarrel
Added exception throw docs for remaing setters
f85df67
@rafarrel
Updated documentation for timeElapsed and refactored reference timest…
4ca2e8e 
…amp names for increment
@rafarrel
Updated documentation for timeChanged
6119da1
@rafarrel
Simplified convert interface and began adding documentation
567cd60
@rafarrel
Updated documentation for castTime
57bb94e
@rafarrel
Added test for unix time now() (passing)
1c0cb56
@rafarrel
Added tests for unix time convert to/from base
36315bd
@rafarrel
Added tests for GpsTime (failing)
9e05e80
@rafarrel
Implemented GpsTime (passing)
ce3cdbe
@rafarrel
Removed old comments from standards.cpp
83432c2
@rafarrel
Added documentation for time standard extensibility
cdf45d4
@rafarrel
Fixed typo
64e009c
@rafarrel
Copy link
Contributor Author

Ready to review again.

@rafarrel
Copy link
Contributor Author

rafarrel commented Aug 5, 2024

Removing exception stuff from comparison functions.

@rafarrel rafarrel changed the title [Revamping] Added timestamp utils to mip sdk [DRAFT] Added timestamp utils to mip sdk Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msclissa msclissa msclissa requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@rafarrel rafarrel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafarrel @msclissa