Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: remove CMAKE_CUDA_ARCHITECTURES default #553

Merged
merged 3 commits into from
Aug 15, 2024
Merged

CMake: remove CMAKE_CUDA_ARCHITECTURES default #553

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c18b36
remove CMAKE_CUDA_ARCHITECTURES default
gardner48 Aug 10, 2024
17adcca
clarify changes to CMAKE_CUDA_ARCHITECTURE default
gardner48 Aug 10, 2024
2e3feeb
add version changed
gardner48 Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

### New Features and Enhancements

The default value of `CMAKE_CUDA_ARCHITECTURES` is no longer set to `70` and is
now determined automatically by CMake. Users are encouraged to override the
default value as it varies across compilers and compiler versions.
gardner48 marked this conversation as resolved.
Show resolved Hide resolved

### Bug Fixes

Fixed the loading of ARKStep's default first order explicit method.
Expand Down
4 changes: 0 additions & 4 deletions cmake/SundialsTPLOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ sundials_option(ENABLE_PTHREAD BOOL "Enable Pthreads support" OFF)
# -------------------------------------------------------------
sundials_option(ENABLE_CUDA BOOL "Enable CUDA support" OFF)

# CMake 3.18 adds this option.
sundials_option(CMAKE_CUDA_ARCHITECTURES STRING "Target CUDA architecture" "70"
DEPENDS_ON ENABLE_CUDA)

# -------------------------------------------------------------
# Enable HIP support?
# -------------------------------------------------------------
Expand Down
4 changes: 4 additions & 0 deletions doc/shared/RecentChanges.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

**New Features and Enhancements**

The default value of :cmakeop:`CMAKE_CUDA_ARCHITECTURES` is no longer set to
``70`` and is now determined automatically by CMake. Users are encouraged to
override the default value as it varies across compilers and compiler versions.
gardner48 marked this conversation as resolved.
Show resolved Hide resolved

**Bug Fixes**

Fixed the loading of ARKStep's default first order explicit method.
Expand Down
6 changes: 4 additions & 2 deletions doc/shared/sundials/Install.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,9 +523,11 @@ illustration only.

.. cmakeoption:: CMAKE_CUDA_ARCHITECTURES

Specifies the CUDA architecture to compile for.
Specifies the CUDA architecture to compile for i.e., ``60`` for Pascal,
``70`` Volta, ``80`` for Ampere, ``90`` for Hopper, etc.
gardner48 marked this conversation as resolved.
Show resolved Hide resolved

Default: ``sm_30``
Default: Determined automatically by CMake. Users are encouraged to override
this value as it varies across compilers and compiler versions.
gardner48 marked this conversation as resolved.
Show resolved Hide resolved

.. cmakeoption:: EXAMPLES_ENABLE_C

Expand Down
Loading