Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/print warning #552

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Bugfix/print warning #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97be008
replace print_warning usage that was missed
balos1 Aug 6, 2024
fc4fd52
changelog
balos1 Aug 6, 2024
ed97ffb
Apply suggestions from code review
gardner48 Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@

Fixed the loading of ARKStep's default first order explicit method.

Fixed a CMake bug regarding usage of missing "print_warning" macro
that was only triggered when the deprecated `CUDA_ARCH` option was used.

### Deprecation Notices

## Changes to SUNDIALS in release 7.1.1
Expand Down
4 changes: 2 additions & 2 deletions cmake/SundialsDeprecated.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@ endif()
#

if(DEFINED CUDA_ARCH)
print_warning("The CMake option CUDA_ARCH is deprecated. "
"Use CMAKE_CUDA_ARCHITECTURES instead.")
message(DEPRECATION "The CMake option CUDA_ARCH is deprecated. "
"Use CMAKE_CUDA_ARCHITECTURES instead.")
# convert sm_** to just **
string(REGEX MATCH "[0-9]+" arch_name "${CUDA_ARCH}")
set(CMAKE_CUDA_ARCHITECTURES
Expand Down
3 changes: 3 additions & 0 deletions doc/shared/RecentChanges.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,7 @@

Fixed the loading of ARKStep's default first order explicit method.

Fixed a CMake bug regarding usage of missing "print_warning" macro
that was only triggered when the deprecated ``CUDA_ARCH`` option was used.

**Deprecation Notices**
Loading