Add macro for consistent sunrealtype formatting

.clang-format

@@ -79,7 +79,7 @@ EmptyLineAfterAccessModifier                  : Never
 EmptyLineBeforeAccessModifier                 : Always
 ExperimentalAutoDetectBinPacking              : false
 FixNamespaceComments                          : true
-IncludeBlocks                   : Regroup
+IncludeBlocks                   : Preserve
 IncludeCategories               :
 - Regex                           : '^(<|"(gtest|gmock|isl|json)/)'
   Priority                        : 1

.github/dependabot.yml

@@ -0,0 +1,8 @@
+version: 2
+updates:
+
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      # Check for updates to GitHub Actions every week
+      interval: "weekly"

.github/workflows/check-clang-format.yml

@@ -12,7 +12,7 @@ jobs:
       image: ghcr.io/llnl/sundials_spack_cache:llvm-17.0.4-h4lflucc3v2vage45opbo2didtcuigsn.spack
     steps:
       - name: Install git
-        run: | 
+        run: |
           apt update
           apt install -y git
 
@@ -26,18 +26,18 @@ jobs:
 
       - name: Print clang-format version
         run: clang-format --version
-      
+
       - name: Run checker on code
         run: |
-          ./scripts/format.sh .
-      
+          ./scripts/format.sh benchmarks examples include src test
+
       - name: Run git diff to see if anything changed
         run: /usr/bin/git diff --name-only --exit-code
-      
+
       - name: Run git diff if we failed
         if: failure()
         run:  /usr/bin/git diff > diff
-      
+
       - name: Archive diff if we failed
         uses: actions/upload-artifact@v3
         if: failure()

.github/workflows/macos-latest.yml

@@ -25,9 +25,13 @@ jobs:
     - uses: actions/checkout@v3
 
     - name: Configure CMake
-      # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
-      # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
-      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
+      # Configure CMake in a 'build' subdirectory.
+      run: |
+        cmake \
+        -B ${{github.workspace}}/build \
+        -D CMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} \
+        -D ENABLE_ALL_WARNINGS=ON \
+        -D ENABLE_WARNINGS_AS_ERRORS=ON
 
     - name: Build
       # Build your program with the given configuration

.github/workflows/ubuntu-clang-latest.yml

@@ -21,8 +21,9 @@ jobs:
       fail-fast: false
       max-parallel: 2
       matrix:
-        # 2 is what all other builds use (its the default), so skip it here
-        logging_level: [0, 1, 3, 4, 5] 
+        # Level 2 is also used in other builds (it's the default) but include it
+        # here to ensure it's tested with all warning flags
+        logging_level: [0, 1, 2, 3, 4, 5]
 
     steps:
     - name: Install LLVM and Clang
@@ -33,9 +34,16 @@ jobs:
     - uses: actions/checkout@v3
 
     - name: Configure CMake
-      # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
-      # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
-      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_C_COMPILER=$(which clang) -DCMAKE_CXX_COMPILER=$(which clang++) -DSUNDIALS_LOGGING_LEVEL=${{matrix.logging_level}}
+      # Configure CMake in a 'build' subdirectory.
+      run: |
+        cmake \
+        -B ${{github.workspace}}/build \
+        -D CMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} \
+        -D CMAKE_C_COMPILER=$(which clang) \
+        -D CMAKE_CXX_COMPILER=$(which clang++) \
+        -D SUNDIALS_LOGGING_LEVEL=${{matrix.logging_level}} \
+        -D ENABLE_ALL_WARNINGS=ON \
+        -D ENABLE_WARNINGS_AS_ERRORS=ON
 
     - name: Build
       # Build your program with the given configuration
@@ -57,9 +65,16 @@ jobs:
     - uses: actions/checkout@v3
 
     - name: Configure CMake
-      # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
-      # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
-      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_C_COMPILER=$(which clang) -DCMAKE_CXX_COMPILER=$(which clang++) -DSUNDIALS_BUILD_WITH_PROFILING=${{matrix.profiling}}
+      # Configure CMake in a 'build' subdirectory.
+      run: |
+        cmake \
+        -B ${{github.workspace}}/build \
+        -D CMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} \
+        -D CMAKE_C_COMPILER=$(which clang) \
+        -D CMAKE_CXX_COMPILER=$(which clang++) \
+        -D SUNDIALS_BUILD_WITH_PROFILING=${{matrix.profiling}} \
+        -D ENABLE_ALL_WARNINGS=ON \
+        -D ENABLE_WARNINGS_AS_ERRORS=ON
 
     - name: Build
       # Build your program with the given configuration

.github/workflows/double-precision.yml → .github/workflows/ubuntu-latest.yml

@@ -1,8 +1,11 @@
 #
-name: Build and Test - Ubuntu/gcc double precision (TPLs, no GPUs)
+name: Build and Test - Ubuntu/gcc (TPLs, no GPUs)
 
 on:
   push:
+    branches:
+      - main
+      - develop
   pull_request:
   merge_group:
   workflow_dispatch:
@@ -21,8 +24,21 @@ jobs:
       max-parallel: 2
       matrix:
         indexsize: [32, 64]
-        precision: ['double']
-        buildtype: ['Debug', 'Release']
+        # Disable extended tests until compiler warnings are addressed
+        precision: ['single', 'double']
+        buildtype: ['Debug', 'Release', 'RelWithDebInfo']
+        exclude:
+          - buildtype: Debug
+            precision: single
+          # - buildtype: Debug
+          #   precision: extended
+          - buildtype: Release
+            precision: single
+          # - buildtype: Release
+          #   precision: extended
+          - buildtype: RelWithDebInfo
+            precision: double
+
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3

.github/workflows/windows-latest-mingw.yml

@@ -14,27 +14,55 @@ env:
   BUILD_TYPE: Release
 
 jobs:
-  buil_and_test:
+  build_and_test:
     runs-on: windows-latest
 
+    defaults:
+      run:
+        # Use MSYS2 as default shell
+        shell: msys2 {0}
+
+    strategy:
+      matrix:
+        msystem: [MINGW64, MINGW32]
+        include:
+          - msystem: MINGW64
+            target-prefix: mingw-w64-x86_64
+          - msystem: MINGW32
+            target-prefix: mingw-w64-i686
+
     steps:
     - uses: actions/checkout@v3
 
     - uses: msys2/setup-msys2@v2
       with:
-        msystem: mingw64
+        msystem: ${{ matrix.msystem }}
+        update: true
+        release: false
+        install: >-
+            base-devel
+            ${{ matrix.target-prefix }}-cmake
+            ${{ matrix.target-prefix }}-cc
+            ${{ matrix.target-prefix }}-openblas
+            ${{ matrix.target-prefix }}-suitesparse
 
     - name: Configure CMake
-      # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
-      # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
-      run: cmake -G "MinGW Makefiles" -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DSUNDIALS_BUILD_WITH_PROFILING=ON -DSUNDIALS_LOGGING_LEVEL=2 -DSUNDIALS_TEST_UNITTESTS=OFF -DEXAMPLES_ENABLE_CXX=ON
+      # Configure CMake in a 'build' subdirectory
+      run: |
+        cmake \
+          -B ${GITHUB_WORKSPACE}/build \
+          -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} \
+          -DSUNDIALS_BUILD_WITH_PROFILING=ON \
+          -DSUNDIALS_LOGGING_LEVEL=2 \
+          -DSUNDIALS_TEST_UNITTESTS=OFF \
+          -DEXAMPLES_ENABLE_CXX=ON \
+          -DENABLE_KLU=ON
 
     - name: Build
-      # Build your program with the given configuration
-      run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}
+      # Build program
+      run: cmake --build ${GITHUB_WORKSPACE}/build
 
     - name: Test
       working-directory: ${{github.workspace}}/build
-      # Execute tests defined by the CMake configuration.
-      # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
-      run: ctest -C ${{env.BUILD_TYPE}}
+      # Execute tests
+      run: ctest

.gitlab-ci.yml

@@ -126,6 +126,8 @@ stages:
 
 # This is where jobs are included.
 include:
+  - project: 'lc-templates/id_tokens'
+    file: 'id_tokens.yml'
   - local: .gitlab/quartz-templates.yml
   - local: .gitlab/quartz-jobs.yml
   - local: .gitlab/lassen-templates.yml

.gitmodules

@@ -7,3 +7,6 @@
 [submodule "test/answers"]
 	path = test/answers
 	url = https://github.com/sundials-codes/answers.git
+[submodule "external/sundials-addon-example"]
+	path = external/sundials-addon-example
+	url = https://github.com/sundials-codes/sundials-addon-example.git

.readthedocs.yaml

@@ -14,6 +14,7 @@ build:
     - graphviz
 
 # Build documentation in the doc/ directory with Sphinx
+# TODO(DJG): Once multiple references are fixed, add fail_on_warning: true
 sphinx:
    configuration: doc/superbuild/source/conf.py