Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Update Compiler Warnings, Enable Warnings as Errors #484

Merged
merged 33 commits into from
May 20, 2024
Merged

CI: Update Compiler Warnings, Enable Warnings as Errors #484

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
1b5986f
warnings as errors in github actions
gardner48 May 16, 2024
2cad780
remove -Wno-deprecated-declarations
gardner48 May 16, 2024
4e146d8
add -Wcast-qual to ENABLE_ALL_WARNINGS
gardner48 May 16, 2024
16485be
add -Wdouble-promotion to ENABLE_ALL_WARNINGS
gardner48 May 16, 2024
38ae328
add -Wmissing-declarations to ENABLE_ALL_WARNINGS
gardner48 May 16, 2024
1a251aa
add -Wshadow to ENABLE_ALL_WARNINGS
gardner48 May 16, 2024
9165c51
Merge branch 'develop' into ci/compiler-warnings
gardner48 May 16, 2024
c87410c
make some flags conditional, add conversion flags from Jeknins tests
gardner48 May 16, 2024
e44af52
Merge branch 'develop' into ci/compiler-warnings
gardner48 May 16, 2024
80a2e6e
Merge branch 'develop' into ci/compiler-warnings
gardner48 May 17, 2024
9ce019a
fix warnings in unit tests
gardner48 May 17, 2024
777635c
fix example warnings
gardner48 May 17, 2024
11964df
gko::lend is deprecated
gardner48 May 17, 2024
79891a3
work around ginkgo test compile error
gardner48 May 17, 2024
491a4c2
formatting
gardner48 May 17, 2024
45b1578
remove reference
gardner48 May 17, 2024
417134e
use gko::lend based on Ginkgo version
gardner48 May 17, 2024
64621b9
fixes for Ginkgo < 1.6
gardner48 May 17, 2024
989742e
rename shadowed variable in vec benchmark
gardner48 May 17, 2024
dc9d1a6
fix shadowed variables in trilinos vector, examples
gardner48 May 18, 2024
65ff531
fix warnings in profiling test
gardner48 May 18, 2024
03a4544
fix warnings in diffusion benchmark
gardner48 May 18, 2024
301da20
formatting
gardner48 May 18, 2024
10b3c84
fix more benchmark warnings
gardner48 May 18, 2024
cee6c0e
add include
gardner48 May 20, 2024
99109ca
skip -Wmissing-declarations with Fortran interfaces
gardner48 May 20, 2024
4ed7093
add comment
gardner48 May 20, 2024
b277bde
regen Fortran interfaces
gardner48 May 20, 2024
58683d1
skip -Wcast-qual with Fortran interfaces
gardner48 May 20, 2024
6b46209
move fused op prototypes to impl.h
gardner48 May 20, 2024
06ac344
formatting
gardner48 May 20, 2024
8e7ad10
fix warnings, linking error with gtest test
gardner48 May 20, 2024
1a6a210
add missing include
gardner48 May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmake/SundialsSetupCompilers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ endif()
if(ENABLE_ALL_WARNINGS)
message(STATUS "Enabling all compiler warnings")

set(CMAKE_C_FLAGS "-Wall -Wpedantic -Wextra -Wno-unused-parameter -Wno-deprecated-declarations -Wno-unused-function ${CMAKE_C_FLAGS}")
set(CMAKE_CXX_FLAGS "-Wall -Wpedantic -Wextra -Wno-unused-parameter -Wno-deprecated-declarations -Wno-unused-function ${CMAKE_CXX_FLAGS}")
set(CMAKE_C_FLAGS "-Wall -Wpedantic -Wextra -Wshadow -Wmissing-declarations -Wcast-qual -Wdouble-promotion -Wno-unused-parameter -Wno-unused-function ${CMAKE_C_FLAGS}")
set(CMAKE_CXX_FLAGS "-Wall -Wpedantic -Wextra -Wshadow -Wmissing-declarations -Wcast-qual -Wdouble-promotion -Wno-unused-parameter -Wno-unused-function ${CMAKE_CXX_FLAGS}")
set(CMAKE_Fortran_FLAGS "-Wall -Wpedantic -Wno-unused-dummy-argument -Wno-c-binding-type -ffpe-summary=none ${CMAKE_Fortran_FLAGS}")
endif()

Expand Down
3 changes: 0 additions & 3 deletions test/env/docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,6 @@ else # single
export SUNDIALS_TEST_INTEGER_PRECISION=10
fi

# FindMPI fails with this ON
export SUNDIALS_ENABLE_WARNINGS_AS_ERRORS=OFF

# ------------------------------------------------------------------------------
# Third party libraries
# ------------------------------------------------------------------------------
Expand Down
Loading