Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling in sunmatrix #390

Merged

Conversation

balos1
Copy link
Member

@balos1 balos1 commented Dec 11, 2023

No description provided.

@balos1 balos1 added this to the SUNDIALS 7.0.0 milestone Dec 11, 2023
@balos1 balos1 changed the title error handling in sumatrix error handling in sunmatrix Dec 11, 2023
include/sundials/sundials_matrix.h Show resolved Hide resolved
doc/shared/sunmatrix/SUNMatrix_MagmaDense.rst Outdated Show resolved Hide resolved
doc/shared/sunmatrix/SUNMatrix_MagmaDense.rst Outdated Show resolved Hide resolved
doc/shared/sunmatrix/SUNMatrix_OneMklDense.rst Outdated Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Outdated Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Show resolved Hide resolved
Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments/questions.

src/sunmatrix/band/sunmatrix_band.c Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Outdated Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Outdated Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Outdated Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Outdated Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Outdated Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Show resolved Hide resolved
Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor issues.

src/sunmatrix/dense/sunmatrix_dense.c Show resolved Hide resolved
src/sunmatrix/sparse/sunmatrix_sparse.c Outdated Show resolved Hide resolved
doc/shared/sunmatrix/SUNMatrix_Operations.rst Show resolved Hide resolved
src/sunmatrix/band/sunmatrix_band.c Outdated Show resolved Hide resolved
src/sunmatrix/band/sunmatrix_band.c Outdated Show resolved Hide resolved
src/sunmatrix/band/sunmatrix_band.c Outdated Show resolved Hide resolved
src/sunmatrix/band/sunmatrix_band.c Outdated Show resolved Hide resolved
src/sunmatrix/onemkldense/sunmatrix_onemkldense.cpp Outdated Show resolved Hide resolved
src/sunmatrix/onemkldense/sunmatrix_onemkldense.cpp Outdated Show resolved Hide resolved
src/sunmatrix/onemkldense/sunmatrix_onemkldense.cpp Outdated Show resolved Hide resolved
src/sunmatrix/onemkldense/sunmatrix_onemkldense.cpp Outdated Show resolved Hide resolved
src/sunmatrix/onemkldense/sunmatrix_onemkldense.cpp Outdated Show resolved Hide resolved
@balos1 balos1 merged commit 3766a32 into feature/error-handling-staging Dec 15, 2023
9 of 10 checks passed
@balos1 balos1 deleted the feature/error-handling-sunmatrix branch December 15, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants