Bugfix/windows ninja #300
Closed
Bugfix/windows ninja #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drreynolds
previously approved these changes
Jul 7, 2023
balos1
force-pushed
the
bugfix/windows-ninja
branch
from
36dcd93
to
7849126
Compare
|
@gardner48 Please review this PR |
gardner48
requested changes
Jul 19, 2023
There was a problem hiding this comment.
This change could break existing builds, do we know if the Ninja user needs both static and shared libraries installed together?
Some files still use MPI_C_COMPILER or MPI_INCLUDE_PATH
nvector/parallel/fmod/CMakeLists.txt
nvector/parallel/CMakeLists.txt
nvector/manyvector/fmod/CMakeLists.txt
nvector/mpiplusx/fmod/CMakeLists.txt
nvector/petsc/CMakeLists.txt
sunmatrix/slunrloc/CMakeLists.txt
sunnonlinsol/petscsnes/CMakeLists.txt
The examples also use these variables but that might be less of an issue.
| set_target_properties(${_actual_target_name} PROPERTIES | ||
| OUTPUT_NAME ${tgt_output_name} | ||
| CLEAN_DIRECT_OUTPUT 1 | ||
| ) |
There was a problem hiding this comment.
This changes the installed static library name to have the _static suffix e.g., libsundials_cvode_static.a rather than libsundials_cvode.a and could break user builds.
|
Closing this for now since we do not want to change the installed library name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches from https://github.com/spack/spack/pull/38776/files. Opening PR now to trigger testing.