Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Minor updates to docs
  • Loading branch information
gardner48 authored Oct 29, 2024
1 parent 005591c commit fcb683c
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 26 deletions.
6 changes: 3 additions & 3 deletions doc/shared/sundials/Install.rst
Original file line number Diff line number Diff line change
Expand Up @@ -870,16 +870,16 @@ illustration only.

.. cmakeoption:: MPIEXEC_PREFLAGS

Specifies flags that come before the MPI executable, but after ``MPIEXEC_EXECUTABLE``,
``MPIEXEC_NUMPROC_FLAG``, and ``MPIEXEC_MAX_NUMPROCS``.
Specifies flags that come directly after ``MPIEXEC_EXECUTABLE`` and before
``MPIEXEC_NUMPROC_FLAG`` and ``MPIEXEC_MAX_NUMPROCS``.

Default: none

.. note:: This option is triggered only if MPI is enabled (``ENABLE_MPI`` is ``ON``).

.. cmakeoption:: MPIEXEC_POSTFLAGS

Specifies flags that come after the MPI executable but before any other program arguments.
Specifies flags that come after the executable to run but before any other program arguments.

Default: none

Expand Down
46 changes: 23 additions & 23 deletions doc/superbuild/source/developers/testing/CI.rst
Original file line number Diff line number Diff line change
Expand Up @@ -166,18 +166,18 @@ Take for example, this Tioga job:

.. code-block:: YAML
tioga_rocmcc_620_tpls:
parallel:
matrix:
- COMPILER_SPEC: [email protected]
AMDGPU_TARGET: [gfx90a]
variables:
# have to use ginkgo@master because our spack version does not have [email protected]: yet (which seems to be needed)
# similarly, we need a newer magma than available to compile with 'rocm@6:' so we turn it off
SPEC: "%${COMPILER_SPEC} cstd=99 cxxstd=14 precision=double amdgpu_target=${AMDGPU_TARGET} +rocm+mpi~magma+ginkgo+kokkos ^ginkgo@master+rocm amdgpu_target=${AMDGPU_TARGET} ^kokkos+rocm amdgpu_target=${AMDGPU_TARGET}"
before_script:
- module load rocmcc/6.2.0-magic
extends: [.sundials_job_on_tioga]
tioga_rocmcc_620_tpls:
parallel:
matrix:
- COMPILER_SPEC: [email protected]
AMDGPU_TARGET: [gfx90a]
variables:
# have to use ginkgo@master because our spack version does not have [email protected]: yet (which seems to be needed)
# similarly, we need a newer magma than available to compile with 'rocm@6:' so we turn it off
SPEC: "%${COMPILER_SPEC} cstd=99 cxxstd=14 precision=double amdgpu_target=${AMDGPU_TARGET} +rocm+mpi~magma+ginkgo+kokkos ^ginkgo@master+rocm amdgpu_target=${AMDGPU_TARGET} ^kokkos+rocm amdgpu_target=${AMDGPU_TARGET}"
before_script:
- module load rocmcc/6.2.0-magic
extends: [.sundials_job_on_tioga]
The ``parallel:`` and ``matrix:`` keywords could be used to enable creating multiple jobs
with different variable values for each instance of the job, e.g., one job using
Expand All @@ -196,17 +196,17 @@ section of the job, e.g.,

.. code-block:: YAML
tioga_rocmcc_620_tpls:
parallel:
matrix:
- COMPILER_SPEC: [email protected]
AMDGPU_TARGET: [gfx90a]
variables:
ON_TIOGA: "OFF" # disable this job
SPEC: "%${COMPILER_SPEC} cstd=99 cxxstd=14 precision=double amdgpu_target=${AMDGPU_TARGET} +rocm+mpi~magma+ginkgo+kokkos ^ginkgo@master+rocm amdgpu_target=${AMDGPU_TARGET} ^kokkos+rocm amdgpu_target=${AMDGPU_TARGET}"
before_script:
- module load rocmcc/6.2.0-magic
extends: [.sundials_job_on_tioga]
tioga_rocmcc_620_tpls:
parallel:
matrix:
- COMPILER_SPEC: [email protected]
AMDGPU_TARGET: [gfx90a]
variables:
ON_TIOGA: "OFF" # disable this job
SPEC: "%${COMPILER_SPEC} cstd=99 cxxstd=14 precision=double amdgpu_target=${AMDGPU_TARGET} +rocm+mpi~magma+ginkgo+kokkos ^ginkgo@master+rocm amdgpu_target=${AMDGPU_TARGET} ^kokkos+rocm amdgpu_target=${AMDGPU_TARGET}"
before_script:
- module load rocmcc/6.2.0-magic
extends: [.sundials_job_on_tioga]
These variables can also be set when manually or scheduling a pipeline in the GitLab UI.

Expand Down

0 comments on commit fcb683c

Please sign in to comment.