Skip to content

Commit

Permalink
Revert "try setting mpiexec_executable to flux run"
Browse files Browse the repository at this point in the history
This reverts commit dc37d96.
  • Loading branch information
balos1 committed Oct 28, 2024
1 parent 83001eb commit 13c09e7
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 16 deletions.
25 changes: 9 additions & 16 deletions .gitlab/build_and_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -143,16 +143,6 @@ install_dir="${build_root}/install_${job_unique_id}_${hostconfig//.cmake/}"

cmake_exe=`grep 'CMake executable' ${hostconfig_path} | cut -d ':' -f 2 | xargs`

# If using flux, append "run" after the flux executable path
if [[ "${MPIEXEC_EXECUTABLE}" == "flux" ]]
then
MPIEXEC_EXECUTABLE="$(which ${MPIEXEC_EXECUTABLE}) run"
flux jobs
flux resource list
else
MPIEXEC_EXECUTABLE="$(which ${MPIEXEC_EXECUTABLE})"
fi

# Build
if [[ "${option}" != "--deps-only" && "${option}" != "--test-only" ]]
then
Expand All @@ -161,6 +151,9 @@ then
echo "~ Host-config: ${hostconfig_path}"
echo "~ Build Dir: ${build_dir}"
echo "~ Project Dir: ${project_dir}"
echo "~ MPIEXEC_EXECUTABLE: ${MPIEXEC_EXECUTABLE}"
echo "~ MPIEXEC_PREFLAGS: ${MPIEXEC_PREFLAGS}"
echo "~ MPIEXEC_POSTFLAGS: ${MPIEXEC_POSTFLAGS}"
echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"

echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
Expand All @@ -183,19 +176,19 @@ then
$cmake_exe \
-C "${hostconfig_path}" \
-DCMAKE_INSTALL_PREFIX=${install_dir} \
-DMPIEXEC_EXECUTABLE="${MPIEXEC_EXECUTABLE}" \
-DMPIEXEC_PREFLAGS="${MPIEXEC_PREFLAGS}" \
-DMPIEXEC_POSTFLAGS="${MPIEXEC_POSTFLAGS}" \
-DMPIEXEC_EXECUTABLE=$(which $MPIEXEC_EXECUTABLE) \
-DMPIEXEC_PREFLAGS=${MPIEXEC_PREFLAGS} \
-DMPIEXEC_POSTFLAGS=${MPIEXEC_POSTFLAGS} \
-DSUNDIALS_CALIPER_OUTPUT_DIR="${CALIPER_DIR}/Release/${hostname}/${sundials_version}" \
"${project_dir}"

else
$cmake_exe \
-C "${hostconfig_path}" \
-DCMAKE_INSTALL_PREFIX=${install_dir} \
-DMPIEXEC_EXECUTABLE="${MPIEXEC_EXECUTABLE}" \
-DMPIEXEC_PREFLAGS="${MPIEXEC_PREFLAGS}" \
-DMPIEXEC_POSTFLAGS="${MPIEXEC_POSTFLAGS}" \
-DMPIEXEC_EXECUTABLE=$(which $MPIEXEC_EXECUTABLE) \
-DMPIEXEC_PREFLAGS=${MPIEXEC_PREFLAGS} \
-DMPIEXEC_POSTFLAGS=${MPIEXEC_POSTFLAGS} \
"${project_dir}"
fi

Expand Down
1 change: 1 addition & 0 deletions .gitlab/jobs/tioga.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
.sundials_job_on_tioga:
variables:
MPIEXEC_EXECUTABLE: "flux"
MPIEXEC_PREFLAGS: "run"
extends: [.custom_job, .job_on_tioga]

# --- Builds with HIP
Expand Down

0 comments on commit 13c09e7

Please sign in to comment.