Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing and testing improvements #312

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Parsing and testing improvements #312

wants to merge 2 commits into from
+439 −325

Conversation

ldowen
Copy link
Collaborator

@ldowen ldowen commented Nov 5, 2024 •
edited
Loading

Summary

  • This PR is a (refactoring, bugfix, feature, something else)
  • It does the following:
    • Splits timer init and parsing into a separate file
    • Fixes parsing so that None does not remain a string of "None" but always becomes a python None
    • Adds default Adiak outputs for number of Spheral nodes
    • Fixes IO in SpheralController and in certain tests to allow IO to be fully turned off
    • Adds a test that intentionally fails to ensure testing system is running the files

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#111)
  • LLNLSpheral PR has passed all tests.

@ldowen
Split timer init and parsing into separate file, fix way inputs are p…
1e1c08f 
…arsed so that None string always becomes None type, added default adiak outputs for number of nodes, fixed IO for SpheralController and certain tests, added an intentional failing test
@ldowen ldowen self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen Awaiting requested review from jmikeowen

@mdavis36 mdavis36 Awaiting requested review from mdavis36

At least 1 approving review is required to merge this pull request.

Assignees

@ldowen ldowen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ldowen