(DNND) Custom Point Type #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KIwabuchi
commented
May 29, 2024
| if (NOT ygm_FOUND) | ||
| FetchContent_Declare( | ||
| ygm | ||
| GIT_REPOSITORY https://github.com/LLNL/ygm.git | ||
| GIT_TAG develop # v${SALTATLAS_YGM_VERSION} | ||
| GIT_TAG v0.7-dev |
There was a problem hiding this comment.
@steiltre I need to change the YGM version to v0.7-dev. Is this okay for you? This is the only location where this PR affects DHNSW.
There was a problem hiding this comment.
This is good. The develop branch of YGM will be deleted at some point (assuming we like the new v0.7-dev style of naming).
…re/dnnd_custom_point_type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables DNND to support custom point types.
This PR depends on LLNL/ygm#209.